maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Optimize comparisons to empty string. 

Geo-mean performance improvement of 0.2% (-0.3% - 0.9% @ 95% CI).

Differential Revision: http://reviews.llvm.org/D6569

llvm-svn: 223728
This commit is contained in:
Peter Collingbourne 2014-12-09 01:02:12 +00:00
parent c8cf2b88bc
commit c5b84a53f7
1 changed files with 16 additions and 0 deletions
llgo/irgen
strings.go

16
llgo/irgen/strings.go
View File

@ -24,7 +24,23 @@ func (fr *frame) concatenateStrings(lhs, rhs *govalue) *govalue {
return newValue(result[0], types.Typ[types.String]) return newValue(result[0], types.Typ[types.String])
} }
func (fr *frame) compareStringEmpty(v llvm.Value) *govalue {
len := fr.builder.CreateExtractValue(v, 1, "")
result := fr.builder.CreateIsNull(len, "")
result = fr.builder.CreateZExt(result, llvm.Int8Type(), "")
return newValue(result, types.Typ[types.Bool])
}
func (fr *frame) compareStrings(lhs, rhs *govalue, op token.Token) *govalue { func (fr *frame) compareStrings(lhs, rhs *govalue, op token.Token) *govalue {
if op == token.EQL {
if lhs.value.IsNull() {
return fr.compareStringEmpty(rhs.value)
}
if rhs.value.IsNull() {
return fr.compareStringEmpty(lhs.value)
}
}
result := fr.runtime.strcmp.call(fr, lhs.value, rhs.value)[0] result := fr.runtime.strcmp.call(fr, lhs.value, rhs.value)[0]
zero := llvm.ConstNull(fr.types.inttype) zero := llvm.ConstNull(fr.types.inttype)
var pred llvm.IntPredicate var pred llvm.IntPredicate