maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lsan] Try to fix test failure due to compiler optimization 

Summary:
The SanitizerCommon-lsan-x86_64-Linux test failed due to the address of
the very first allocation ending up in the stack through "delete[]".
Workaround this by performing another allocation. The issue was only
present with optimization enabled, the test would pass with -O0.

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D46650

llvm-svn: 332020
This commit is contained in:
Peter Wu 2018-05-10 19:02:32 +00:00
parent e28faed768
commit c58988a908
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_death_callback_test.cc
View File

@ -2,12 +2,6 @@
// REQUIRES: stable-runtime // REQUIRES: stable-runtime
// For standalone LSan on x86 we have a problem: compiler spills the address
// of allocated at line 42 memory thus memory block allocated in Leak() function
// ends up to be classified as reachable despite the fact we zero out 'sink' at
// the last line of main function. The problem doesn't reproduce with ASan because
// quarantine prohibits memory block reuse for different allocations.
// XFAIL: lsan-x86
// XFAIL: ubsan // XFAIL: ubsan
#include <sanitizer/common_interface_defs.h> #include <sanitizer/common_interface_defs.h>
@ -31,7 +25,10 @@ void MaybeInit(int *uninitialized) {
__attribute__((noinline)) __attribute__((noinline))
void Leak() { void Leak() {
sink = new char[100]; // trigger lsan report. // Trigger lsan report. Two attempts in case the address of the first
// allocation remained on the stack.
sink = new char[100];
sink = new char[100];
} }
int main(int argc, char **argv) { int main(int argc, char **argv) {