From c5326ca9bb107a309a886481b5e3cd1a5c3dd28e Mon Sep 17 00:00:00 2001 From: Rui Ueyama Date: Sat, 1 Feb 2014 00:26:33 +0000 Subject: [PATCH] [PECOFF] Add a TODO. llvm-svn: 200599 --- lld/lib/Driver/WinLinkDriver.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lld/lib/Driver/WinLinkDriver.cpp b/lld/lib/Driver/WinLinkDriver.cpp index 5e21a3d66249..830a4eaebf8a 100644 --- a/lld/lib/Driver/WinLinkDriver.cpp +++ b/lld/lib/Driver/WinLinkDriver.cpp @@ -701,6 +701,9 @@ WinLinkDriver::parse(int argc, const char *argv[], PECOFFLinkingContext &ctx, // Handle /machine before parsing all the other options, as the target machine // type affects how to handle other options. For example, x86 needs the // leading underscore to mangle symbols, while x64 doesn't need it. + // + // TODO: If /machine option is missing, we probably should take a look at + // the magic byte of the first object file to set machine type. if (llvm::opt::Arg *inputArg = parsedArgs->getLastArg(OPT_machine)) { StringRef arg = inputArg->getValue(); llvm::COFF::MachineTypes type = stringToMachineType(arg);