maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[PECOFF] Add a TODO. 

llvm-svn: 200599
This commit is contained in:
Rui Ueyama 2014-02-01 00:26:33 +00:00
parent 8ae1627733
commit c5326ca9bb
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lld/lib/Driver/WinLinkDriver.cpp
View File

@ -701,6 +701,9 @@ WinLinkDriver::parse(int argc, const char *argv[], PECOFFLinkingContext &ctx,
// Handle /machine before parsing all the other options, as the target machine
// type affects how to handle other options. For example, x86 needs the
// leading underscore to mangle symbols, while x64 doesn't need it.
//
// TODO: If /machine option is missing, we probably should take a look at
// the magic byte of the first object file to set machine type.
if (llvm::opt::Arg *inputArg = parsedArgs->getLastArg(OPT_machine)) {
StringRef arg = inputArg->getValue();
llvm::COFF::MachineTypes type = stringToMachineType(arg);