maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix the warning for divide by zero to be a bit more robust. ;] 

Previously, it only ever fired for zeros which formed null pointers.
Now, hilariously, in C++98 this was almost anything. Including tricks
like warning on the divisor in this code:

typedef char c3[3];
size_t f(c3* ptr) {
  return (sizeof(ptr) / sizeof(*ptr)) / (size_t)(!(sizeof(ptr) % sizeof(*ptr)));
}

Why the RHS of the outer divide is a null pointer constant is a sordid
tale of sorrow. Anyways, the committee fixed this for C++11 and onward
as part of core isssue 903, and Richard recently implemented this fix
causing the warning to go away here (and elsewhere).

This patch restores the warning here and adds it for numerous other
somewhat obvious gaffes:

int g(int x) {
  return x / (int)(0.0);
}

The patch is essentially just using the full power of our constant
folding in Clang to produce the warning, but insisting that it must fold
to an *integer* which is zero so that we don't get false positives
anywhere.

llvm-svn: 183970
This commit is contained in:
Chandler Carruth 2013-06-14 08:57:18 +00:00
parent ef2ee4fec2
commit c41c8b3a4a
2 changed files with 33 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
clang/lib/Sema/SemaExpr.cpp
View File

@ -6496,10 +6496,11 @@ QualType Sema::CheckMultiplyDivideOperands(ExprResult &LHS, ExprResult &RHS,
return InvalidOperands(Loc, LHS, RHS);
// Check for division by zero.
if (IsDiv &&
RHS.get()->isNullPointerConstant(Context,
Expr::NPC_ValueDependentIsNotNull))
DiagRuntimeBehavior(Loc, RHS.get(), PDiag(diag::warn_division_by_zero)
llvm::APSInt RHSValue;
if (IsDiv && !RHS.get()->isValueDependent() &&
RHS.get()->EvaluateAsInt(RHSValue, Context) && RHSValue == 0)
DiagRuntimeBehavior(Loc, RHS.get(),
PDiag(diag::warn_division_by_zero)
<< RHS.get()->getSourceRange());
return compType;
@ -6525,9 +6526,11 @@ QualType Sema::CheckRemainderOperands(
return InvalidOperands(Loc, LHS, RHS);
// Check for remainder by zero.
if (RHS.get()->isNullPointerConstant(Context,
Expr::NPC_ValueDependentIsNotNull))
DiagRuntimeBehavior(Loc, RHS.get(), PDiag(diag::warn_remainder_by_zero)
llvm::APSInt RHSValue;
if (!RHS.get()->isValueDependent() &&
RHS.get()->EvaluateAsInt(RHSValue, Context) && RHSValue == 0)
DiagRuntimeBehavior(Loc, RHS.get(),
PDiag(diag::warn_remainder_by_zero)
<< RHS.get()->getSourceRange());
return compType;

21
clang/test/SemaCXX/warn-div-or-rem-by-zero.cpp Normal file
View File

@ -0,0 +1,21 @@
// RUN: %clang_cc1 -verify %s
// RUN: %clang_cc1 -std=c++11 -verify %s
// RUN: %clang_cc1 -std=c++1y -verify %s
void div() {
(void)(42 / 0); // expected-warning{{division by zero is undefined}}
(void)(42 / false); // expected-warning{{division by zero is undefined}}
(void)(42 / !1); // expected-warning{{division by zero is undefined}}
(void)(42 / (1 - 1)); // expected-warning{{division by zero is undefined}}
(void)(42 / !(1 + 1)); // expected-warning{{division by zero is undefined}}
(void)(42 / (int)(0.0)); // expected-warning{{division by zero is undefined}}
}
void rem() {
(void)(42 % 0); // expected-warning{{remainder by zero is undefined}}
(void)(42 % false); // expected-warning{{remainder by zero is undefined}}
(void)(42 % !1); // expected-warning{{remainder by zero is undefined}}
(void)(42 % (1 - 1)); // expected-warning{{remainder by zero is undefined}}
(void)(42 % !(1 + 1)); // expected-warning{{remainder by zero is undefined}}
(void)(42 % (int)(0.0)); // expected-warning{{remainder by zero is undefined}}
}