From c31ef42530713048e4b14d61e25b63af8d1084f8 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Mon, 21 Feb 2022 13:29:37 -0500 Subject: [PATCH] Revert "[ArgPromotion] Regenerate test checks for crash.ll - removed ALL_NEWPM prefix." This reverts commit 52577cd26f26f6428c72395e7337af3fc84bc6f6. Breaks check-llvm, see comments on https://reviews.llvm.org/D120207 --- .../Transforms/ArgumentPromotion/crash.ll | 92 +++++++++---------- 1 file changed, 44 insertions(+), 48 deletions(-) diff --git a/llvm/test/Transforms/ArgumentPromotion/crash.ll b/llvm/test/Transforms/ArgumentPromotion/crash.ll index 7909ef909fb4..d55f4624e0c3 100644 --- a/llvm/test/Transforms/ArgumentPromotion/crash.ll +++ b/llvm/test/Transforms/ArgumentPromotion/crash.ll @@ -1,23 +1,23 @@ ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --scrub-attributes -; RUN: opt -S < %s -inline -argpromotion | FileCheck %s -; RUN: opt -S < %s -passes=inline,argpromotion | FileCheck %s +; RUN: opt -S < %s -inline -argpromotion | FileCheck %s --check-prefix=ARGPROMOTION +; RUN: opt -S < %s -passes=inline,argpromotion | FileCheck %s --check-prefixes=ARGPROMOTION,ALL_NEWPM %S = type { %S* } ; Inlining should nuke the invoke (and any inlined calls) here even with ; argument promotion running along with it. define void @zot() personality i32 (...)* @wibble { -; CHECK-LABEL: define {{[^@]+}}@zot() personality i32 (...)* @wibble { -; CHECK-NEXT: bb: -; CHECK-NEXT: unreachable -; CHECK: hoge.exit: -; CHECK-NEXT: br label [[BB1:%.*]] -; CHECK: bb1: -; CHECK-NEXT: unreachable -; CHECK: bb2: -; CHECK-NEXT: [[TEMP:%.*]] = landingpad { i8*, i32 } -; CHECK-NEXT: cleanup -; CHECK-NEXT: unreachable +; ARGPROMOTION-LABEL: define {{[^@]+}}@zot() personality i32 (...)* @wibble +; ARGPROMOTION-NEXT: bb: +; ARGPROMOTION-NEXT: unreachable +; ARGPROMOTION: hoge.exit: +; ARGPROMOTION-NEXT: br label [[BB1:%.*]] +; ARGPROMOTION: bb1: +; ARGPROMOTION-NEXT: unreachable +; ARGPROMOTION: bb2: +; ARGPROMOTION-NEXT: [[TMP:%.*]] = landingpad { i8*, i32 } +; ARGPROMOTION-NEXT: cleanup +; ARGPROMOTION-NEXT: unreachable ; bb: invoke void @hoge() @@ -27,15 +27,15 @@ bb1: unreachable bb2: - %temp = landingpad { i8*, i32 } + %tmp = landingpad { i8*, i32 } cleanup unreachable } define internal void @hoge() { bb: - %temp = call fastcc i8* @spam(i1 (i8*)* @eggs) - %temp1 = call fastcc i8* @spam(i1 (i8*)* @barney) + %tmp = call fastcc i8* @spam(i1 (i8*)* @eggs) + %tmp1 = call fastcc i8* @spam(i1 (i8*)* @barney) unreachable } @@ -45,58 +45,54 @@ bb: } define internal i1 @eggs(i8* %arg) { -; CHECK-LABEL: define {{[^@]+}}@eggs() { -; CHECK-NEXT: bb: -; CHECK-NEXT: unreachable +; ALL_NEWPM-LABEL: define {{[^@]+}}@eggs() +; ALL_NEWPM-NEXT: bb: +; ALL_NEWPM-NEXT: unreachable ; bb: - %temp = call zeroext i1 @barney(i8* %arg) + %tmp = call zeroext i1 @barney(i8* %arg) unreachable } define internal i1 @barney(i8* %arg) { -; CHECK-LABEL: define {{[^@]+}}@barney() { -; CHECK-NEXT: bb: -; CHECK-NEXT: ret i1 undef -; bb: ret i1 undef } define i32 @test_inf_promote_caller(i32 %arg) { -; CHECK-LABEL: define {{[^@]+}}@test_inf_promote_caller -; CHECK-SAME: (i32 [[ARG:%.*]]) { -; CHECK-NEXT: bb: -; CHECK-NEXT: [[TEMP:%.*]] = alloca [[S:%.*]], align 8 -; CHECK-NEXT: [[TEMP1:%.*]] = alloca [[S]], align 8 -; CHECK-NEXT: [[TEMP2:%.*]] = call i32 @test_inf_promote_callee(%S* [[TEMP]], %S* [[TEMP1]]) -; CHECK-NEXT: ret i32 0 +; ARGPROMOTION-LABEL: define {{[^@]+}}@test_inf_promote_caller +; ARGPROMOTION-SAME: (i32 [[ARG:%.*]]) +; ARGPROMOTION-NEXT: bb: +; ARGPROMOTION-NEXT: [[TMP:%.*]] = alloca [[S:%.*]] +; ARGPROMOTION-NEXT: [[TMP1:%.*]] = alloca [[S]] +; ARGPROMOTION-NEXT: [[TMP2:%.*]] = call i32 @test_inf_promote_callee(%S* [[TMP]], %S* [[TMP1]]) +; ARGPROMOTION-NEXT: ret i32 0 ; bb: - %temp = alloca %S - %temp1 = alloca %S - %temp2 = call i32 @test_inf_promote_callee(%S* %temp, %S* %temp1) + %tmp = alloca %S + %tmp1 = alloca %S + %tmp2 = call i32 @test_inf_promote_callee(%S* %tmp, %S* %tmp1) ret i32 0 } define internal i32 @test_inf_promote_callee(%S* %arg, %S* %arg1) { -; CHECK-LABEL: define {{[^@]+}}@test_inf_promote_callee -; CHECK-SAME: (%S* [[ARG:%.*]], %S* [[ARG1:%.*]]) { -; CHECK-NEXT: bb: -; CHECK-NEXT: [[TEMP:%.*]] = getelementptr [[S:%.*]], %S* [[ARG1]], i32 0, i32 0 -; CHECK-NEXT: [[TEMP2:%.*]] = load %S*, %S** [[TEMP]], align 8 -; CHECK-NEXT: [[TEMP3:%.*]] = getelementptr [[S]], %S* [[ARG]], i32 0, i32 0 -; CHECK-NEXT: [[TEMP4:%.*]] = load %S*, %S** [[TEMP3]], align 8 -; CHECK-NEXT: [[TEMP5:%.*]] = call i32 @test_inf_promote_callee(%S* [[TEMP4]], %S* [[TEMP2]]) -; CHECK-NEXT: ret i32 0 +; ARGPROMOTION-LABEL: define {{[^@]+}}@test_inf_promote_callee +; ARGPROMOTION-SAME: (%S* [[ARG:%.*]], %S* [[ARG1:%.*]]) +; ARGPROMOTION-NEXT: bb: +; ARGPROMOTION-NEXT: [[TMP:%.*]] = getelementptr [[S:%.*]], %S* [[ARG1]], i32 0, i32 0 +; ARGPROMOTION-NEXT: [[TMP2:%.*]] = load %S*, %S** [[TMP]] +; ARGPROMOTION-NEXT: [[TMP3:%.*]] = getelementptr [[S]], %S* [[ARG]], i32 0, i32 0 +; ARGPROMOTION-NEXT: [[TMP4:%.*]] = load %S*, %S** [[TMP3]] +; ARGPROMOTION-NEXT: [[TMP5:%.*]] = call i32 @test_inf_promote_callee(%S* [[TMP4]], %S* [[TMP2]]) +; ARGPROMOTION-NEXT: ret i32 0 ; bb: - %temp = getelementptr %S, %S* %arg1, i32 0, i32 0 - %temp2 = load %S*, %S** %temp - %temp3 = getelementptr %S, %S* %arg, i32 0, i32 0 - %temp4 = load %S*, %S** %temp3 - %temp5 = call i32 @test_inf_promote_callee(%S* %temp4, %S* %temp2) + %tmp = getelementptr %S, %S* %arg1, i32 0, i32 0 + %tmp2 = load %S*, %S** %tmp + %tmp3 = getelementptr %S, %S* %arg, i32 0, i32 0 + %tmp4 = load %S*, %S** %tmp3 + %tmp5 = call i32 @test_inf_promote_callee(%S* %tmp4, %S* %tmp2) ret i32 0 }