maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lld/mac] make a few "named parameter comments" more consistent 

Most of LLVM and almost all of lld/MachO uses `/*foo=*/bar` style.
No behavior change.
This commit is contained in:
Nico Weber 2021-04-22 10:44:56 -04:00
parent e99b98cb1b
commit c1b2a7bfbf
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lld/MachO/SyntheticSections.cpp
View File

@ -1102,7 +1102,7 @@ void macho::createSyntheticSymbols() {
auto addHeaderSymbol = [](const char *name) {
symtab->addSynthetic(name, in.header->isec, 0,
/*privateExtern=*/true,
/*includeInSymtab*/ false);
/*includeInSymtab=*/false);
};
switch (config->outputType) {
@ -1114,13 +1114,13 @@ void macho::createSyntheticSymbols() {
// Otherwise, it's an absolute symbol.
if (config->isPic)
symtab->addSynthetic("__mh_execute_header", in.header->isec, 0,
/*privateExtern*/ false,
/*includeInSymbtab*/ true);
/*privateExtern=*/false,
/*includeInSymbtab=*/true);
else
symtab->addSynthetic("__mh_execute_header",
/*isec*/ nullptr, 0,
/*privateExtern*/ false,
/*includeInSymbtab*/ true);
/*privateExtern=*/false,
/*includeInSymbtab=*/true);
break;
// The following symbols are N_SECT symbols, even though the header is not

5
lld/MachO/UnwindInfoSection.cpp
View File

@ -179,8 +179,9 @@ void UnwindInfoSectionImpl<Ptr>::prepareRelocations(InputSection *isec) {
// symbols for them in the GOT.
Symbol *&s = personalityTable[{referentIsec, r.addend}];
if (s == nullptr) {
s = make<Defined>("<internal>", nullptr, referentIsec, r.addend, 0,
false, false, false);
s = make<Defined>("<internal>", /*file=*/nullptr, referentIsec,
r.addend, /*size=*/0, /*isWeakDef=*/false,
/*isExternal=*/false, /*isPrivateExtern=*/false);
in.got->addEntry(s);
}
r.referent = s;