maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Hoist culling of -Wunreachable-code from headers before we even run the analysis. 

llvm-svn: 202200
This commit is contained in:
Ted Kremenek 2014-02-25 22:35:37 +00:00
parent 69140d2c0f
commit c1b2875e69
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
clang/lib/Sema/AnalysisBasedWarnings.cpp
View File

@ -66,12 +66,6 @@ namespace {
UnreachableCodeHandler(Sema &s) : S(s) {}
void HandleUnreachable(SourceLocation L, SourceRange R1, SourceRange R2) {
// As a heuristic prune all diagnostics not in the main file. Currently
// the majority of warnings in headers are false positives. These
// are largely caused by configuration state, e.g. preprocessor
// defined code, etc.
if (!S.getSourceManager().isInMainFile(L))
return;
S.Diag(L, diag::warn_unreachable) << R1 << R2;
}
};
@ -79,6 +73,16 @@ namespace {
/// CheckUnreachable - Check for unreachable code.
static void CheckUnreachable(Sema &S, AnalysisDeclContext &AC) {
// As a heuristic prune all diagnostics not in the main file. Currently
// the majority of warnings in headers are false positives. These
// are largely caused by configuration state, e.g. preprocessor
// defined code, etc.
//
// Note that this is also a performance optimization. Analyzing
// headers many times can be expensive.
if (!S.getSourceManager().isInMainFile(AC.getDecl()->getLocStart()))
return;
UnreachableCodeHandler UC(S);
reachable_code::FindUnreachableCode(AC, UC);
}