maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[flang] clean up for review 

Original-commit: flang-compiler/f18@9bf94ea39c
Reviewed-on: https://github.com/flang-compiler/f18/pull/538
Tree-same-pre-rewrite: false
This commit is contained in:
peter klausler 2019-07-01 13:54:34 -07:00
parent 8e93226e74
commit c140c1e674
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
flang/lib/evaluate/variable.cc
View File

@ -319,8 +319,8 @@ template<typename T> Expr<SubscriptInteger> Designator<T>::LEN() const {
} }
Expr<SubscriptInteger> ProcedureDesignator::LEN() const { Expr<SubscriptInteger> ProcedureDesignator::LEN() const {
// TODO pmk: this needs more thought for assumed-length // TODO: this needs more thought for assumed-length
// character functions, &c. // character functions, intrinsics, &c.
return std::visit( return std::visit(
common::visitors{ common::visitors{
[](const Symbol *s) { return SymbolLEN(*s); }, [](const Symbol *s) { return SymbolLEN(*s); },

5
flang/lib/semantics/expression.cc
View File

@ -1652,8 +1652,9 @@ MaybeExpr ExpressionAnalyzer::Analyze(const parser::Expr::PercentLoc &x) {
// Use the actual source for the name of the call for error reporting. // Use the actual source for the name of the call for error reporting.
if (MaybeExpr arg{Analyze(x.v.value())}) { if (MaybeExpr arg{Analyze(x.v.value())}) {
parser::CharBlock at{GetContextualMessages().at()}; parser::CharBlock at{GetContextualMessages().at()};
CHECK(at[0] == '%'); CHECK(at.size() >= 4);
parser::CharBlock loc{at.begin() + 1, at.end()}; parser::CharBlock loc{at.begin() + 1, 3};
CHECK(loc == "loc");
return MakeFunctionRef( return MakeFunctionRef(
loc, ActualArguments{ActualArgument{std::move(*arg)}}); loc, ActualArguments{ActualArgument{std::move(*arg)}});
} }