We don't actually need to check the implicit object argument's

conversion a second time for a conversion candidate (with the real
acting context), because the only problems we would find are access or
ambiguity issues that won't be diagnosed until we pick this
candidate. Add a test case to prove it to myself.

llvm-svn: 111526
This commit is contained in:
Douglas Gregor 2010-08-19 17:02:01 +00:00
parent 0d7e9538db
commit c0afc67608
2 changed files with 18 additions and 15 deletions

View File

@ -3767,21 +3767,6 @@ Sema::AddConversionCandidate(CXXConversionDecl *Conversion,
return;
}
// Make sure that the actual object argument initialization will work, when
// it comes down to it. This takes into account the actual acting context.
if (ConversionContext->getCanonicalDecl()
!= ActingContext->getCanonicalDecl()) {
ImplicitConversionSequence ObjectConvertICS
= TryObjectArgumentInitialization(From->getType(), Conversion,
ActingContext);
if (ObjectConvertICS.isBad()) {
Candidate.Viable = false;
Candidate.FailureKind = ovl_fail_bad_conversion;
Candidate.Conversions[0] = ObjectConvertICS;
return;
}
}
// We won't go through a user-define type conversion function to convert a
// derived to base as such conversions are given Conversion Rank. They only
// go through a copy constructor. 13.3.3.1.2-p4 [over.ics.user]

View File

@ -306,4 +306,22 @@ namespace rdar8018274 {
void test2(UeberDerived ud) {
int i = ud; // expected-error{{ambiguous conversion from derived class 'rdar8018274::SuperDerived' to base class 'rdar8018274::Base'}}
}
struct Base2 {
operator int();
};
struct Base3 {
operator int();
};
struct Derived23 : Base2, Base3 {
using Base2::operator int;
};
struct ExtraDerived23 : Derived23 { };
void test3(ExtraDerived23 ed) {
int i = ed;
}
}