maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Use TempFile in llvm-ar. NFC. 

llvm-svn: 318127
This commit is contained in:
Rafael Espindola 2017-11-14 01:21:15 +00:00
parent 0a5ebdbf6f
commit c02eacf4c4
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
llvm/lib/Object/ArchiveWriter.cpp
View File

@ -488,14 +488,12 @@ Error llvm::writeArchive(StringRef ArcName,
Kind = object::Archive::K_GNU64;
}
SmallString<128> TmpArchive;
int TmpArchiveFD;
if (auto EC = sys::fs::createUniqueFile(ArcName + ".temp-archive-%%%%%%%.a",
TmpArchiveFD, TmpArchive))
return errorCodeToError(EC);
Expected<sys::fs::TempFile> Temp =
sys::fs::TempFile::create(ArcName + ".temp-archive-%%%%%%%.a");
if (!Temp)
return Temp.takeError();
ToolOutputFile Output(TmpArchive, TmpArchiveFD);
raw_fd_ostream &Out = Output.os();
raw_fd_ostream Out(Temp->FD, false);
if (Thin)
Out << "!<thin>\n";
else
@ -507,8 +505,7 @@ Error llvm::writeArchive(StringRef ArcName,
for (const MemberData &M : Data)
Out << M.Header << M.Data << M.Padding;
Output.keep();
Out.close();
Out.flush();
// At this point, we no longer need whatever backing memory
// was used to generate the NewMembers. On Windows, this buffer
@ -522,6 +519,5 @@ Error llvm::writeArchive(StringRef ArcName,
// closed before we attempt to rename.
OldArchiveBuf.reset();
sys::fs::rename(TmpArchive, ArcName);
return Error::success();
return Temp->keep(ArcName);
}