maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clangd] Make categorical features 64 bit in DecisionForest Model. 

CodeCompletionContext::Kind has 36 Kinds. The completion model used to
support categorical features of 32 cardinality.
Due to this clangd tests were failing asan tests due to overflow.

This patch makes the completion model support 64 cardinality of
categorical features by storing ENUM Features as uint64_t instead of
uint32_t.

Verified that this fixes the asan failures.

Latency: 6.7ms (old) VS 6.8ms (new) per 1000 predictions.

Differential Revision: https://reviews.llvm.org/D97770
This commit is contained in:
Utkarsh Saxena 2021-03-02 15:23:36 +01:00
parent 0caf736d7e
commit bf935a034b
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp
View File

@ -51,7 +51,7 @@ std::vector<Example> generateRandomDataset(int NumExamples) {
: RandInt(20));
E.setSemaSaysInScope(FlipCoin(0.5)); // Boolean.
E.setScope(RandInt(4)); // 4 Scopes.
E.setContextKind(RandInt(32)); // 32 Context kinds.
E.setContextKind(RandInt(36)); // 36 Context kinds.
E.setIsInstanceMember(FlipCoin(0.5)); // Boolean.
E.setHadContextType(FlipCoin(0.6)); // Boolean.
E.setHadSymbolType(FlipCoin(0.6)); // Boolean.

11
clang-tools-extra/clangd/quality/CompletionModelCodegen.py
View File

@ -131,18 +131,19 @@ def gen_header_code(features_json, cpp_class, filename):
feature, feature))
elif f["kind"] == "ENUM":
setters.append(
"void set%s(unsigned V) { %s = 1 << V; }" % (feature, feature))
"void set%s(unsigned V) { %s = 1LL << V; }" % (feature, feature))
else:
raise ValueError("Unhandled feature type.", f["kind"])
# Class members represent all the features of the Example.
class_members = [
"uint32_t %s = 0;" % f['name']
"uint%d_t %s = 0;"
% (64 if f["kind"] == "ENUM" else 32, f['name'])
for f in features_json
]
getters = [
"LLVM_ATTRIBUTE_ALWAYS_INLINE uint32_t get%s() const { return %s; }"
% (f['name'], f['name'])
"LLVM_ATTRIBUTE_ALWAYS_INLINE uint%d_t get%s() const { return %s; }"
% (64 if f["kind"] == "ENUM" else 32, f['name'], f['name'])
for f in features_json
]
nline = "\n "
@ -245,7 +246,7 @@ def gen_cpp_code(forest_json, features_json, filename, cpp_class):
%s
#define BIT(X) (1 << X)
#define BIT(X) (1LL << X)
%s