Regenerate select test. NFCI.

llvm-svn: 323265
This commit is contained in:
Simon Pilgrim 2018-01-23 21:50:46 +00:00
parent a075ce04d8
commit bf3c39877e
1 changed files with 74 additions and 53 deletions

View File

@ -1,3 +1,4 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -codegenprepare -S < %s | FileCheck %s ; RUN: opt -codegenprepare -S < %s | FileCheck %s
target triple = "x86_64-unknown-unknown" target triple = "x86_64-unknown-unknown"
@ -5,78 +6,82 @@ target triple = "x86_64-unknown-unknown"
; Nothing to sink and convert here. ; Nothing to sink and convert here.
define i32 @no_sink(double %a, double* %b, i32 %x, i32 %y) { define i32 @no_sink(double %a, double* %b, i32 %x, i32 %y) {
; CHECK-LABEL: @no_sink(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[LOAD:%.*]] = load double, double* [[B:%.*]], align 8
; CHECK-NEXT: [[CMP:%.*]] = fcmp olt double [[LOAD]], [[A:%.*]]
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], i32 [[X:%.*]], i32 [[Y:%.*]]
; CHECK-NEXT: ret i32 [[SEL]]
;
entry: entry:
%load = load double, double* %b, align 8 %load = load double, double* %b, align 8
%cmp = fcmp olt double %load, %a %cmp = fcmp olt double %load, %a
%sel = select i1 %cmp, i32 %x, i32 %y %sel = select i1 %cmp, i32 %x, i32 %y
ret i32 %sel ret i32 %sel
; CHECK-LABEL: @no_sink(
; CHECK: %load = load double, double* %b, align 8
; CHECK: %cmp = fcmp olt double %load, %a
; CHECK: %sel = select i1 %cmp, i32 %x, i32 %y
; CHECK: ret i32 %sel
} }
; An 'fdiv' is expensive, so sink it rather than speculatively execute it. ; An 'fdiv' is expensive, so sink it rather than speculatively execute it.
define float @fdiv_true_sink(float %a, float %b) { define float @fdiv_true_sink(float %a, float %b) {
; CHECK-LABEL: @fdiv_true_sink(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = fcmp ogt float [[A:%.*]], 1.000000e+00
; CHECK-NEXT: br i1 [[CMP]], label [[SELECT_TRUE_SINK:%.*]], label [[SELECT_END:%.*]]
; CHECK: select.true.sink:
; CHECK-NEXT: [[DIV:%.*]] = fdiv float [[A]], [[B:%.*]]
; CHECK-NEXT: br label [[SELECT_END]]
; CHECK: select.end:
; CHECK-NEXT: [[SEL:%.*]] = phi float [ [[DIV]], [[SELECT_TRUE_SINK]] ], [ 2.000000e+00, [[ENTRY:%.*]] ]
; CHECK-NEXT: ret float [[SEL]]
;
entry: entry:
%div = fdiv float %a, %b %div = fdiv float %a, %b
%cmp = fcmp ogt float %a, 1.0 %cmp = fcmp ogt float %a, 1.0
%sel = select i1 %cmp, float %div, float 2.0 %sel = select i1 %cmp, float %div, float 2.0
ret float %sel ret float %sel
; CHECK-LABEL: @fdiv_true_sink(
; CHECK: %cmp = fcmp ogt float %a, 1.0
; CHECK: br i1 %cmp, label %select.true.sink, label %select.end
; CHECK: select.true.sink:
; CHECK: %div = fdiv float %a, %b
; CHECK: br label %select.end
; CHECK: select.end:
; CHECK: %sel = phi float [ %div, %select.true.sink ], [ 2.000000e+00, %entry ]
; CHECK: ret float %sel
} }
define float @fdiv_false_sink(float %a, float %b) { define float @fdiv_false_sink(float %a, float %b) {
; CHECK-LABEL: @fdiv_false_sink(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = fcmp ogt float [[A:%.*]], 3.000000e+00
; CHECK-NEXT: br i1 [[CMP]], label [[SELECT_END:%.*]], label [[SELECT_FALSE_SINK:%.*]]
; CHECK: select.false.sink:
; CHECK-NEXT: [[DIV:%.*]] = fdiv float [[A]], [[B:%.*]]
; CHECK-NEXT: br label [[SELECT_END]]
; CHECK: select.end:
; CHECK-NEXT: [[SEL:%.*]] = phi float [ 4.000000e+00, [[ENTRY:%.*]] ], [ [[DIV]], [[SELECT_FALSE_SINK]] ]
; CHECK-NEXT: ret float [[SEL]]
;
entry: entry:
%div = fdiv float %a, %b %div = fdiv float %a, %b
%cmp = fcmp ogt float %a, 3.0 %cmp = fcmp ogt float %a, 3.0
%sel = select i1 %cmp, float 4.0, float %div %sel = select i1 %cmp, float 4.0, float %div
ret float %sel ret float %sel
; CHECK-LABEL: @fdiv_false_sink(
; CHECK: %cmp = fcmp ogt float %a, 3.0
; CHECK: br i1 %cmp, label %select.end, label %select.false.sink
; CHECK: select.false.sink:
; CHECK: %div = fdiv float %a, %b
; CHECK: br label %select.end
; CHECK: select.end:
; CHECK: %sel = phi float [ 4.000000e+00, %entry ], [ %div, %select.false.sink ]
; CHECK: ret float %sel
} }
define float @fdiv_both_sink(float %a, float %b) { define float @fdiv_both_sink(float %a, float %b) {
; CHECK-LABEL: @fdiv_both_sink(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = fcmp ogt float [[A:%.*]], 5.000000e+00
; CHECK-NEXT: br i1 [[CMP]], label [[SELECT_TRUE_SINK:%.*]], label [[SELECT_FALSE_SINK:%.*]]
; CHECK: select.true.sink:
; CHECK-NEXT: [[DIV1:%.*]] = fdiv float [[A]], [[B:%.*]]
; CHECK-NEXT: br label [[SELECT_END:%.*]]
; CHECK: select.false.sink:
; CHECK-NEXT: [[DIV2:%.*]] = fdiv float [[B]], [[A]]
; CHECK-NEXT: br label [[SELECT_END]]
; CHECK: select.end:
; CHECK-NEXT: [[SEL:%.*]] = phi float [ [[DIV1]], [[SELECT_TRUE_SINK]] ], [ [[DIV2]], [[SELECT_FALSE_SINK]] ]
; CHECK-NEXT: ret float [[SEL]]
;
entry: entry:
%div1 = fdiv float %a, %b %div1 = fdiv float %a, %b
%div2 = fdiv float %b, %a %div2 = fdiv float %b, %a
%cmp = fcmp ogt float %a, 5.0 %cmp = fcmp ogt float %a, 5.0
%sel = select i1 %cmp, float %div1, float %div2 %sel = select i1 %cmp, float %div1, float %div2
ret float %sel ret float %sel
; CHECK-LABEL: @fdiv_both_sink(
; CHECK: %cmp = fcmp ogt float %a, 5.0
; CHECK: br i1 %cmp, label %select.true.sink, label %select.false.sink
; CHECK: select.true.sink:
; CHECK: %div1 = fdiv float %a, %b
; CHECK: br label %select.end
; CHECK: select.false.sink:
; CHECK: %div2 = fdiv float %b, %a
; CHECK: br label %select.end
; CHECK: select.end:
; CHECK: %sel = phi float [ %div1, %select.true.sink ], [ %div2, %select.false.sink ]
; CHECK: ret float %sel
} }
; But if the select is marked unpredictable, then don't turn it into a branch. ; But if the select is marked unpredictable, then don't turn it into a branch.
@ -84,8 +89,8 @@ entry:
define float @unpredictable_select(float %a, float %b) { define float @unpredictable_select(float %a, float %b) {
; CHECK-LABEL: @unpredictable_select( ; CHECK-LABEL: @unpredictable_select(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
; CHECK-NEXT: [[DIV:%.*]] = fdiv float %a, %b ; CHECK-NEXT: [[DIV:%.*]] = fdiv float [[A:%.*]], [[B:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = fcmp ogt float %a, 1.000000e+00 ; CHECK-NEXT: [[CMP:%.*]] = fcmp ogt float [[A]], 1.000000e+00
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], float [[DIV]], float 2.000000e+00, !unpredictable !0 ; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], float [[DIV]], float 2.000000e+00, !unpredictable !0
; CHECK-NEXT: ret float [[SEL]] ; CHECK-NEXT: ret float [[SEL]]
; ;
@ -101,13 +106,16 @@ entry:
; An 'fadd' is not too expensive, so it's ok to speculate. ; An 'fadd' is not too expensive, so it's ok to speculate.
define float @fadd_no_sink(float %a, float %b) { define float @fadd_no_sink(float %a, float %b) {
; CHECK-LABEL: @fadd_no_sink(
; CHECK-NEXT: [[ADD:%.*]] = fadd float [[A:%.*]], [[B:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = fcmp ogt float 6.000000e+00, [[A]]
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], float [[ADD]], float 7.000000e+00
; CHECK-NEXT: ret float [[SEL]]
;
%add = fadd float %a, %b %add = fadd float %a, %b
%cmp = fcmp ogt float 6.0, %a %cmp = fcmp ogt float 6.0, %a
%sel = select i1 %cmp, float %add, float 7.0 %sel = select i1 %cmp, float %add, float 7.0
ret float %sel ret float %sel
; CHECK-LABEL: @fadd_no_sink(
; CHECK: %sel = select i1 %cmp, float %add, float 7.0
} }
; Possible enhancement: sinkability is only calculated with the direct ; Possible enhancement: sinkability is only calculated with the direct
@ -115,15 +123,20 @@ define float @fadd_no_sink(float %a, float %b) {
; taken into account. ; taken into account.
define float @fdiv_no_sink(float %a, float %b) { define float @fdiv_no_sink(float %a, float %b) {
; CHECK-LABEL: @fdiv_no_sink(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[DIV:%.*]] = fdiv float [[A:%.*]], [[B:%.*]]
; CHECK-NEXT: [[ADD:%.*]] = fadd float [[DIV]], [[B]]
; CHECK-NEXT: [[CMP:%.*]] = fcmp ogt float [[A]], 1.000000e+00
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], float [[ADD]], float 8.000000e+00
; CHECK-NEXT: ret float [[SEL]]
;
entry: entry:
%div = fdiv float %a, %b %div = fdiv float %a, %b
%add = fadd float %div, %b %add = fadd float %div, %b
%cmp = fcmp ogt float %a, 1.0 %cmp = fcmp ogt float %a, 1.0
%sel = select i1 %cmp, float %add, float 8.0 %sel = select i1 %cmp, float %add, float 8.0
ret float %sel ret float %sel
; CHECK-LABEL: @fdiv_no_sink(
; CHECK: %sel = select i1 %cmp, float %add, float 8.0
} }
; Do not transform the CFG if the select operands may have side effects. ; Do not transform the CFG if the select operands may have side effects.
@ -132,24 +145,32 @@ declare i64* @bar(i32, i32, i32)
declare i64* @baz(i32, i32, i32) declare i64* @baz(i32, i32, i32)
define i64* @calls_no_sink(i32 %in) { define i64* @calls_no_sink(i32 %in) {
; CHECK-LABEL: @calls_no_sink(
; CHECK-NEXT: [[CALL1:%.*]] = call i64* @bar(i32 1, i32 2, i32 3)
; CHECK-NEXT: [[CALL2:%.*]] = call i64* @baz(i32 1, i32 2, i32 3)
; CHECK-NEXT: [[TOBOOL:%.*]] = icmp ne i32 [[IN:%.*]], 0
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[TOBOOL]], i64* [[CALL1]], i64* [[CALL2]]
; CHECK-NEXT: ret i64* [[SEL]]
;
%call1 = call i64* @bar(i32 1, i32 2, i32 3) %call1 = call i64* @bar(i32 1, i32 2, i32 3)
%call2 = call i64* @baz(i32 1, i32 2, i32 3) %call2 = call i64* @baz(i32 1, i32 2, i32 3)
%tobool = icmp ne i32 %in, 0 %tobool = icmp ne i32 %in, 0
%sel = select i1 %tobool, i64* %call1, i64* %call2 %sel = select i1 %tobool, i64* %call1, i64* %call2
ret i64* %sel ret i64* %sel
; CHECK-LABEL: @calls_no_sink(
; CHECK: %sel = select i1 %tobool, i64* %call1, i64* %call2
} }
define i32 @sdiv_no_sink(i32 %a, i32 %b) { define i32 @sdiv_no_sink(i32 %a, i32 %b) {
; CHECK-LABEL: @sdiv_no_sink(
; CHECK-NEXT: [[DIV1:%.*]] = sdiv i32 [[A:%.*]], [[B:%.*]]
; CHECK-NEXT: [[DIV2:%.*]] = sdiv i32 [[B]], [[A]]
; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i32 [[A]], 5
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], i32 [[DIV1]], i32 [[DIV2]]
; CHECK-NEXT: ret i32 [[SEL]]
;
%div1 = sdiv i32 %a, %b %div1 = sdiv i32 %a, %b
%div2 = sdiv i32 %b, %a %div2 = sdiv i32 %b, %a
%cmp = icmp sgt i32 %a, 5 %cmp = icmp sgt i32 %a, 5
%sel = select i1 %cmp, i32 %div1, i32 %div2 %sel = select i1 %cmp, i32 %div1, i32 %div2
ret i32 %sel ret i32 %sel
; CHECK-LABEL: @sdiv_no_sink(
; CHECK: %sel = select i1 %cmp, i32 %div1, i32 %div2
} }