diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index 3014369c887f..67a3497efb44 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -2290,7 +2290,13 @@ static bool mergeDeclAttribute(Sema &S, NamedDecl *D, NewAttr = S.mergeAlwaysInlineAttr(D, AA->getRange(), &S.Context.Idents.get(AA->getSpelling()), AttrSpellingListIndex); - else if (const auto *MA = dyn_cast(Attr)) + else if (S.getLangOpts().CUDA && isa(D) && + (isa(Attr) || isa(Attr) || + isa(Attr))) { + // CUDA target attributes are part of function signature for + // overloading purposes and must not be merged. + return false; + } else if (const auto *MA = dyn_cast(Attr)) NewAttr = S.mergeMinSizeAttr(D, MA->getRange(), AttrSpellingListIndex); else if (const auto *OA = dyn_cast(Attr)) NewAttr = S.mergeOptimizeNoneAttr(D, OA->getRange(), AttrSpellingListIndex); diff --git a/clang/test/SemaCUDA/function-overload.cu b/clang/test/SemaCUDA/function-overload.cu index 3c78600b174e..ff1db14b494e 100644 --- a/clang/test/SemaCUDA/function-overload.cu +++ b/clang/test/SemaCUDA/function-overload.cu @@ -379,3 +379,14 @@ __host__ __device__ void test_host_device_single_side_overloading() { HostReturnTy ret3 = host_only_function(1); HostReturnTy2 ret4 = host_only_function(1.0f); } + +// Verify that we allow overloading function templates. +template __host__ T template_overload(const T &a) { return a; }; +template __device__ T template_overload(const T &a) { return a; }; + +__host__ void test_host_template_overload() { + template_overload(1); // OK. Attribute-based overloading picks __host__ variant. +} +__device__ void test_device_template_overload() { + template_overload(1); // OK. Attribute-based overloading picks __device__ variant. +} diff --git a/clang/test/SemaCUDA/target_attr_inheritance.cu b/clang/test/SemaCUDA/target_attr_inheritance.cu new file mode 100644 index 000000000000..29daf4d179a8 --- /dev/null +++ b/clang/test/SemaCUDA/target_attr_inheritance.cu @@ -0,0 +1,29 @@ +// Verifies correct inheritance of target attributes during template +// instantiation and specialization. + +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple nvptx64-nvidia-cuda -fsyntax-only -fcuda-is-device -verify %s + +#include "Inputs/cuda.h" + +// Function must inherit target attributes during instantiation, but not during +// specialization. +template __host__ __device__ T function_template(const T &a); + +// Specialized functions have their own attributes. +// expected-note@+1 {{candidate function not viable: call to __host__ function from __device__ function}} +template <> __host__ float function_template(const float &from); + +// expected-note@+1 {{candidate function not viable: call to __device__ function from __host__ function}} +template <> __device__ double function_template(const double &from); + +__host__ void hf() { + function_template(1.0f); // OK. Specialization is __host__. + function_template(2.0); // expected-error {{no matching function for call to 'function_template'}} + function_template(1); // OK. Instantiated function template is HD. +} +__device__ void df() { + function_template(3.0f); // expected-error {{no matching function for call to 'function_template'}} + function_template(4.0); // OK. Specialization is __device__. + function_template(1); // OK. Instantiated function template is HD. +}