From bea2d5e47867687c8d2f95bd70ed9a77d19eeb6e Mon Sep 17 00:00:00 2001 From: Raphael Isemann Date: Tue, 23 Feb 2021 12:10:39 +0100 Subject: [PATCH] [lldb][NFC] Remove unused ValueObject::LogValueObject functions Those functions aren't called anywhere. For debugging purposes we usually have Dump() methods (which already exist in some semi-functional form in ValueObject). --- lldb/include/lldb/Core/ValueObject.h | 4 ---- lldb/source/Core/ValueObject.cpp | 15 --------------- 2 files changed, 19 deletions(-) diff --git a/lldb/include/lldb/Core/ValueObject.h b/lldb/include/lldb/Core/ValueObject.h index 2042baae97ed..9fc9d6da5360 100644 --- a/lldb/include/lldb/Core/ValueObject.h +++ b/lldb/include/lldb/Core/ValueObject.h @@ -656,10 +656,6 @@ public: CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data, const ExecutionContext &exe_ctx, CompilerType type); - void LogValueObject(Log *log); - - void LogValueObject(Log *log, const DumpValueObjectOptions &options); - lldb::ValueObjectSP Persist(); /// Returns true if this is a char* or a char[] if it is a char* and diff --git a/lldb/source/Core/ValueObject.cpp b/lldb/source/Core/ValueObject.cpp index 8f90ae873160..ec6e95410dac 100644 --- a/lldb/source/Core/ValueObject.cpp +++ b/lldb/source/Core/ValueObject.cpp @@ -2617,21 +2617,6 @@ ValueObjectSP ValueObject::GetValueForExpressionPath_Impl( } } -void ValueObject::LogValueObject(Log *log) { - if (log) - return LogValueObject(log, DumpValueObjectOptions(*this)); -} - -void ValueObject::LogValueObject(Log *log, - const DumpValueObjectOptions &options) { - if (log) { - StreamString s; - Dump(s, options); - if (s.GetSize()) - log->PutCString(s.GetData()); - } -} - void ValueObject::Dump(Stream &s) { Dump(s, DumpValueObjectOptions(*this)); } void ValueObject::Dump(Stream &s, const DumpValueObjectOptions &options) {