maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang] Fix crash on visiting null nestedNameSpecifier. 

Summary: Fix https://github.com/clangd/clangd/issues/293

Reviewers: sammccall

Subscribers: ilya-biryukov, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D76320
This commit is contained in:
Haojian Wu 2020-03-17 21:39:19 +01:00
parent c3df69faa0
commit bd763e2cf7
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang/lib/Sema/SemaTemplate.cpp
View File

@ -5928,7 +5928,9 @@ bool UnnamedLocalNoLinkageFinder::VisitDependentNameType(
bool UnnamedLocalNoLinkageFinder::VisitDependentTemplateSpecializationType(
const DependentTemplateSpecializationType* T) {
return VisitNestedNameSpecifier(T->getQualifier());
if (auto *Q = T->getQualifier())
return VisitNestedNameSpecifier(Q);
return false;
}
bool UnnamedLocalNoLinkageFinder::VisitPackExpansionType(
@ -5982,6 +5984,7 @@ bool UnnamedLocalNoLinkageFinder::VisitTagDecl(const TagDecl *Tag) {
bool UnnamedLocalNoLinkageFinder::VisitNestedNameSpecifier(
NestedNameSpecifier *NNS) {
assert(NNS);
if (NNS->getPrefix() && VisitNestedNameSpecifier(NNS->getPrefix()))
return true;

6
clang/test/Parser/cxx-template-decl.cpp
View File

@ -273,3 +273,9 @@ namespace AnnotateAfterInvalidTemplateId {
namespace PR45063 {
template<class=class a::template b<>> struct X {}; // expected-error {{undeclared identifier 'a'}}
}
namespace NoCrashOnEmptyNestedNameSpecifier {
template <typename FnT,
typename T = typename ABC<FnT>::template arg_t<0>> // expected-error {{no template named 'ABC'}}
void foo(FnT) {}
}