maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

AllocOp: drop redundant verifier check 

The equality check between the rank of a memref and the input size of the
layout affine map in AllocOp::verify is subsumed by the well-formedness check
of the memref type itself.  Drop the redundant check from the verifier since it
is never exercised (the type builder does not allow one to construct a type
that would not pass the verifier check).

PiperOrigin-RevId: 256551247
This commit is contained in:
Alex Zinenko 2019-07-04 07:47:34 -07:00 committed by jpienaar
parent 1bcaa3185d
commit bd17bd299f
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
mlir/lib/StandardOps/Ops.cpp
View File

@ -264,15 +264,6 @@ static LogicalResult verify(AllocOp op) {
AffineMap affineMap = memRefType.getAffineMaps()[0]; AffineMap affineMap = memRefType.getAffineMaps()[0];
// Store number of symbols used in affine map (used in subsequent check). // Store number of symbols used in affine map (used in subsequent check).
numSymbols = affineMap.getNumSymbols(); numSymbols = affineMap.getNumSymbols();
// TODO(zinenko): this check does not belong to AllocOp, or any other op but
// to the type system itself. It has been partially hoisted to Parser but
// remains here in case an AllocOp gets constructed programmatically.
// Remove when we can emit errors directly from *Type::get(...) functions.
//
// Verify that the layout affine map matches the rank of the memref.
if (affineMap.getNumDims() != memRefType.getRank())
return op.emitOpError(
"affine map dimension count must equal memref rank");
} }
unsigned numDynamicDims = memRefType.getNumDynamicDims(); unsigned numDynamicDims = memRefType.getNumDynamicDims();
// Check that the total number of operands matches the number of symbols in // Check that the total number of operands matches the number of symbols in