maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Hexagon] Remove std::hex in favor of format(). 

std::hex is not used anywhere in LLVM code base except for this place,
and it has a known undefined behavior (at least in libstdc++ 4.9.3):
https://llvm.org/bugs/show_bug.cgi?id=18156, which fires in UBSan
bootstrap of LLVM.

llvm-svn: 254547
This commit is contained in:
Alexey Samsonov 2015-12-02 21:13:43 +00:00
parent 194913ffbe
commit bcfabaa05b
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
llvm/lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp
View File

@ -38,6 +38,7 @@
#include "llvm/Support/CommandLine.h"
#include "llvm/Support/Debug.h"
#include "llvm/Support/ELF.h"
#include "llvm/Support/Format.h"
#include "llvm/Support/SourceMgr.h"
#include "llvm/Support/MemoryBuffer.h"
#include "llvm/Support/TargetRegistry.h"
@ -1511,14 +1512,15 @@ unsigned HexagonAsmParser::validateTargetOperandClass(MCParsedAsmOperand &AsmOp,
}
void HexagonAsmParser::OutOfRange(SMLoc IDLoc, long long Val, long long Max) {
std::stringstream errStr;
errStr << "value " << Val << "(0x" << std::hex << Val << std::dec
std::string errStr;
raw_string_ostream ES(errStr);
ES << "value " << Val << "(" << format("0x%" PRIx64, Val)
<< ") out of range: ";
if (Max >= 0)
errStr << "0-" << Max;
ES << "0-" << Max;
else
errStr << Max << "-" << (-Max - 1);
Error(IDLoc, errStr.str().c_str());
ES << Max << "-" << (-Max - 1);
Error(IDLoc, ES.str().c_str());
}
int HexagonAsmParser::processInstruction(MCInst &Inst,