From bcbea2ab84df87983fa9b30e94ea25eda0eb2338 Mon Sep 17 00:00:00 2001 From: Nathan James Date: Mon, 12 Apr 2021 15:13:59 +0100 Subject: [PATCH] [NFC] Remove redundant string copy --- clang/include/clang/AST/TextNodeDumper.h | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/clang/include/clang/AST/TextNodeDumper.h b/clang/include/clang/AST/TextNodeDumper.h index 15ca348f4766..0955c494a74a 100644 --- a/clang/include/clang/AST/TextNodeDumper.h +++ b/clang/include/clang/AST/TextNodeDumper.h @@ -69,10 +69,8 @@ public: return; } - // We need to capture an owning-string in the lambda because the lambda - // is invoked in a deferred manner. - std::string LabelStr(Label); - auto DumpWithIndent = [this, DoAddChild, LabelStr](bool IsLastChild) { + auto DumpWithIndent = [this, DoAddChild, + Label(Label.str())](bool IsLastChild) { // Print out the appropriate tree structure and work out the prefix for // children of this node. For instance: // @@ -89,8 +87,8 @@ public: OS << '\n'; ColorScope Color(OS, ShowColors, IndentColor); OS << Prefix << (IsLastChild ? '`' : '|') << '-'; - if (!LabelStr.empty()) - OS << LabelStr << ": "; + if (!Label.empty()) + OS << Label << ": "; this->Prefix.push_back(IsLastChild ? ' ' : '|'); this->Prefix.push_back(' ');