diff --git a/llvm/lib/Target/ARM64/ARM64InstrFormats.td b/llvm/lib/Target/ARM64/ARM64InstrFormats.td index f78f96fe9f5a..f6811ee6681c 100644 --- a/llvm/lib/Target/ARM64/ARM64InstrFormats.td +++ b/llvm/lib/Target/ARM64/ARM64InstrFormats.td @@ -2901,6 +2901,18 @@ class StorePairNoAlloc opc, bit V, RegisterClass regtype, // True exclusive operations write to and/or read from the system's exclusive // monitors, which as far as a compiler is concerned can be modelled as a // random shared memory address. Hence LoadExclusive mayStore. +// +// Since these instructions have the undefined register bits set to 1 in +// their canonical form, we need a post encoder method to set those bits +// to 1 when encoding these instructions. We do this using the +// fixLoadStoreExclusive function. This function has template parameters: +// +// fixLoadStoreExclusive +// +// hasRs indicates that the instruction uses the Rs field, so we won't set +// it to 1 (and the same for Rt2). We don't need template parameters for +// the other register fields since Rt and Rn are always used. +// let hasSideEffects = 1, mayLoad = 1, mayStore = 1 in class BaseLoadStoreExclusive sz, bit o2, bit L, bit o1, bit o0, dag oops, dag iops, string asm, string operands> @@ -2921,10 +2933,10 @@ class LoadStoreExclusiveSimple sz, bit o2, bit L, bit o1, bit o0, : BaseLoadStoreExclusive { bits<5> reg; bits<5> base; - let Inst{20-16} = 0b11111; - let Inst{14-10} = 0b11111; let Inst{9-5} = base; let Inst{4-0} = reg; + + let PostEncoderMethod = "fixLoadStoreExclusive<0,0>"; } // Simple load acquires don't set the exclusive monitor @@ -2951,10 +2963,11 @@ class LoadExclusivePair sz, bit o2, bit L, bit o1, bit o0, bits<5> dst1; bits<5> dst2; bits<5> base; - let Inst{20-16} = 0b11111; let Inst{14-10} = dst2; let Inst{9-5} = base; let Inst{4-0} = dst1; + + let PostEncoderMethod = "fixLoadStoreExclusive<0,1>"; } // Simple store release operations do not check the exclusive monitor. @@ -2977,11 +2990,11 @@ class StoreExclusive sz, bit o2, bit L, bit o1, bit o0, bits<5> reg; bits<5> base; let Inst{20-16} = status; - let Inst{14-10} = 0b11111; let Inst{9-5} = base; let Inst{4-0} = reg; let Constraints = "@earlyclobber $Ws"; + let PostEncoderMethod = "fixLoadStoreExclusive<1,0>"; } class StoreExclusivePair sz, bit o2, bit L, bit o1, bit o0, diff --git a/llvm/lib/Target/ARM64/MCTargetDesc/ARM64MCCodeEmitter.cpp b/llvm/lib/Target/ARM64/MCTargetDesc/ARM64MCCodeEmitter.cpp index ce96d8e38335..48172d894aa7 100644 --- a/llvm/lib/Target/ARM64/MCTargetDesc/ARM64MCCodeEmitter.cpp +++ b/llvm/lib/Target/ARM64/MCTargetDesc/ARM64MCCodeEmitter.cpp @@ -176,6 +176,11 @@ public: void EncodeInstruction(const MCInst &MI, raw_ostream &OS, SmallVectorImpl &Fixups, const MCSubtargetInfo &STI) const; + + template unsigned + fixLoadStoreExclusive(const MCInst &MI, unsigned EncodedValue, + const MCSubtargetInfo &STI) const; + }; } // end anonymous namespace @@ -560,4 +565,14 @@ void ARM64MCCodeEmitter::EncodeInstruction(const MCInst &MI, raw_ostream &OS, ++MCNumEmitted; // Keep track of the # of mi's emitted. } +template unsigned +ARM64MCCodeEmitter::fixLoadStoreExclusive(const MCInst &MI, + unsigned EncodedValue, + const MCSubtargetInfo &STI) const { + if (!hasRs) EncodedValue |= 0x001F0000; + if (!hasRt2) EncodedValue |= 0x00007C00; + + return EncodedValue; +} + #include "ARM64GenMCCodeEmitter.inc" diff --git a/llvm/test/MC/Disassembler/ARM64/canonical-form.txt b/llvm/test/MC/Disassembler/ARM64/canonical-form.txt new file mode 100644 index 000000000000..6aaa5da3987f --- /dev/null +++ b/llvm/test/MC/Disassembler/ARM64/canonical-form.txt @@ -0,0 +1,5 @@ +# RUN: llvm-mc -triple arm64-apple-darwin --disassemble < %s | FileCheck %s + +0x00 0x08 0x00 0xc8 + +# CHECK: stxr w0, x0, [x0]