maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Simplify as this runs before copy relocations are created. 

llvm-svn: 312807
This commit is contained in:
Rafael Espindola 2017-09-08 18:21:14 +00:00
parent d72d97b3be
commit bb468da200
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lld/ELF/Writer.cpp
View File

@ -1226,12 +1226,6 @@ static void removeUnusedSyntheticSections() {
// with the same name defined in other ELF executable or DSO.
static bool computeIsPreemptible(const SymbolBody &B) {
assert(!B.isLocal());
// Shared symbols resolve to the definition in the DSO. The exceptions are
// symbols with copy relocations (which resolve to .bss) or preempt plt
// entries (which resolve to that plt entry).
if (auto *SS = dyn_cast<SharedSymbol>(&B))
return !SS->CopyRelSec && !SS->NeedsPltAddr;
// Only symbols that appear in dynsym can be preempted.
if (!B.symbol()->includeInDynsym())
return false;
@ -1246,7 +1240,7 @@ static bool computeIsPreemptible(const SymbolBody &B) {
// executables are automatically exported so that the runtime linker
// can try to resolve them. In that case, they are preemptible. So, we
// return true for an undefined symbols in all cases.
if (B.isUndefined())
if (B.isUndefined() || B.isShared())
return true;
// If we have a dynamic list it specifies which local symbols are preemptible.