maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Don't set hidden for a non-external symbol as that would make it extenal. 

Refine codegen for visibility and hidden.  WIP.

llvm-svn: 92118
This commit is contained in:
Mike Stump 2009-12-24 02:33:48 +00:00
parent 3a509cd8cc
commit bb2f57dd39
1 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
clang/lib/CodeGen/CGRTTI.cpp
View File

@ -262,6 +262,7 @@ public:
return llvm::ConstantInt::get(llvm::Type::getInt32Ty(VMContext), n); return llvm::ConstantInt::get(llvm::Type::getInt32Ty(VMContext), n);
} }
// FIXME: unify with getTypeInfoLinkage
bool DecideExtern(QualType Ty) { bool DecideExtern(QualType Ty) {
// For this type, see if all components are never in an anonymous namespace. // For this type, see if all components are never in an anonymous namespace.
if (const MemberPointerType *MPT = Ty->getAs<MemberPointerType>()) if (const MemberPointerType *MPT = Ty->getAs<MemberPointerType>())
@ -269,12 +270,26 @@ public:
&& DecideExtern(QualType(MPT->getClass(), 0))); && DecideExtern(QualType(MPT->getClass(), 0)));
if (const PointerType *PT = Ty->getAs<PointerType>()) if (const PointerType *PT = Ty->getAs<PointerType>())
return DecideExtern(PT->getPointeeType()); return DecideExtern(PT->getPointeeType());
if (const FunctionType *FT = Ty->getAs<FunctionType>()) {
if (DecideExtern(FT->getResultType()) == false)
return false;
if (const FunctionProtoType *FPT = Ty->getAs<FunctionProtoType>()) {
for (unsigned i = 0; i <FPT->getNumArgs(); ++i)
if (DecideExtern(FPT->getArgType(i)) == false)
return false;
for (unsigned i = 0; i <FPT->getNumExceptions(); ++i)
if (DecideExtern(FPT->getExceptionType(i)) == false)
return false;
return true;
}
}
if (const RecordType *RT = Ty->getAs<RecordType>()) if (const RecordType *RT = Ty->getAs<RecordType>())
if (const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl())) if (const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl()))
return !RD->isInAnonymousNamespace() && RD->hasLinkage(); return !RD->isInAnonymousNamespace() && RD->hasLinkage();
return true; return true;
} }
// FIXME: unify with DecideExtern
bool DecideHidden(QualType Ty) { bool DecideHidden(QualType Ty) {
// For this type, see if all components are never hidden. // For this type, see if all components are never hidden.
if (const MemberPointerType *MPT = Ty->getAs<MemberPointerType>()) if (const MemberPointerType *MPT = Ty->getAs<MemberPointerType>())
@ -282,6 +297,19 @@ public:
&& DecideHidden(QualType(MPT->getClass(), 0))); && DecideHidden(QualType(MPT->getClass(), 0)));
if (const PointerType *PT = Ty->getAs<PointerType>()) if (const PointerType *PT = Ty->getAs<PointerType>())
return DecideHidden(PT->getPointeeType()); return DecideHidden(PT->getPointeeType());
if (const FunctionType *FT = Ty->getAs<FunctionType>()) {
if (DecideHidden(FT->getResultType()) == false)
return false;
if (const FunctionProtoType *FPT = Ty->getAs<FunctionProtoType>()) {
for (unsigned i = 0; i <FPT->getNumArgs(); ++i)
if (DecideHidden(FPT->getArgType(i)) == false)
return false;
for (unsigned i = 0; i <FPT->getNumExceptions(); ++i)
if (DecideHidden(FPT->getExceptionType(i)) == false)
return false;
return true;
}
}
if (const RecordType *RT = Ty->getAs<RecordType>()) if (const RecordType *RT = Ty->getAs<RecordType>())
if (const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl())) if (const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl()))
return CGM.getDeclVisibilityMode(RD) == LangOptions::Hidden; return CGM.getDeclVisibilityMode(RD) == LangOptions::Hidden;
@ -305,7 +333,7 @@ public:
Info.push_back(BuildName(Ty, Hidden, Extern)); Info.push_back(BuildName(Ty, Hidden, Extern));
// We always generate these as hidden, only the name isn't hidden. // We always generate these as hidden, only the name isn't hidden.
return finish(GV, Name, /*Hidden=*/true, return finish(GV, Name, /*Hidden=*/Extern ? true : false,
GetLinkageFromExternFlag(Extern)); GetLinkageFromExternFlag(Extern));
} }