maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang][NFC] Add specificity to compatibility hack 

Add specific dates and versions to note about source_location handling.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D123119
This commit is contained in:
Nathan Sidwell 2022-04-05 04:55:04 -07:00
parent fb6596f1ec
commit ba4482f481
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
clang/lib/AST/ExprConstant.cpp
View File

@ -8838,10 +8838,11 @@ bool PointerExprEvaluator::VisitCastExpr(const CastExpr *E) {
E->getType()->getPointeeType());
// 1. We'll allow it in std::allocator::allocate, and anything which that
// calls.
// 2. We'll allow it in the body of std::source_location:current. This is
// necessary for libstdc++'s <source_location>, which gave its
// parameter the type void*, and cast from that back to `const __impl*`
// in the body. (Fixed for new versions in gcc.gnu.org/PR104602).
// 2. HACK 2022-03-28: Work around an issue with libstdc++'s
// <source_location> header. Fixed in GCC 12 and later (2022-04-??).
// We'll allow it in the body of std::source_location::current. GCC's
// implementation had a parameter of type `void*`, and casts from
// that back to `const __impl*` in its body.
if (VoidPtrCastMaybeOK &&
(Info.getStdAllocatorCaller("allocate") ||
IsDeclSourceLocationCurrent(Info.CurrentCall->Callee))) {