maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[ELF] Don't crash when parsing a file with out-of-bounds version references 

Summary:
We were crashing when linking telnetd in FreeBSD because lld was emitting
corrupted output files for --norosegment. In this file the version index of some symbols
was set to 9 but lld only found 8 version definitions.

I am not sure how to create a minimal .so file that also exposes this behaviour so I just added the one that initially caused the error to Inputs/

This partially addresses https://bugs.llvm.org/show_bug.cgi?id=34705

Reviewers: ruiu, rafael, pcc, grimar

Reviewed By: ruiu

Subscribers: emaste, krytarowski

Tags: #lld

Differential Revision: https://reviews.llvm.org/D38397

llvm-svn: 315036
This commit is contained in:
Alexander Richardson 2017-10-05 23:28:34 +00:00
parent 57f089775b
commit b9aa9a5500
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lld/ELF/InputFiles.cpp
View File

@ -780,9 +780,7 @@ template <class ELFT> void SharedFile<ELFT>::parseRest() {
if (VersymIndex >= Verdefs.size()) {
error("corrupt input file: version definition index " +
Twine(VersymIndex) + " for symbol " + Name +
" is greater than the maximum value " +
Twine(Verdefs.size() - 1) + "\n>>> symbol is defined in " +
toString(this));
" is out of bounds\n>>> defined in " + toString(this));
continue;
}
V = Verdefs[VersymIndex];

4
lld/test/ELF/corrupted-version-reference.s
View File

@ -1,8 +1,8 @@
# RUN: llvm-mc -triple=mips64-unknown-freebsd %s -filetype=obj -o %t.o
# RUN: not ld.lld %t.o %S/Inputs/corrupt-version-reference.so -o %t.exe 2>&1 | FileCheck %s
# CHECK: error: corrupt input file: version definition index 9 for symbol __cxa_finalize is greater than the maximum value 8
# CHECK: >>> symbol is defined in {{.+}}/corrupt-version-reference.so
# CHECK: error: corrupt input file: version definition index 9 for symbol __cxa_finalize is out of bounds
# CHECK: >>> defined in {{.+}}/corrupt-version-reference.so
.globl __start
__start: