maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix compiling with clang-cl inside a Visual Studio 2019 16.4 command prompt. 

This was introduced by 0d17410e91 and was preventing from compiling with clang-cl on Windows.
The problem was that clang-cl detects the triple from the current env vars (was x86_64-pc-windows-msvc19.24.28315 for me, as I happen to always run inside a VS2019 cmd prompt).
This commit is contained in:
Alexandre Ganea 2020-01-28 14:48:12 -05:00
parent 7a717d82ff
commit b8c39e9462
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/include/llvm/Support/Compiler.h
View File

@ -25,11 +25,11 @@
#if defined(_MSC_VER)
#include <sal.h>
#if _MSC_VER == 1924
#if _MSC_VER == 1924 && !defined(__clang__)
// See https://developercommunity.visualstudio.com/content/problem/845933/miscompile-boolean-condition-deduced-to-be-always.html
// and thread "[llvm-dev] Longstanding failing tests - clang-tidy, MachO, Polly"
// on llvm-dev Jan 21-23 2020.
#error "MSVC 19.24 version of MSVC is known to miscompile LLVM."
#error "MSVC 19.24 (Visual Studio 2019 version 16.4) is known to miscompile LLVM. Please upgrade to version 16.5+ or use clang-cl."
#endif
#endif