maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang-tidy] Ignore default arguments in modernize-default-member-init 

Summary:
Default member initializers cannot refer to constructor parameters, but modernize-default-member-init was trying to when the default constructor had default arguments.

Change the check to ignore default arguments to the default constructor.

Fixes PR31524.

Reviewers: alexfh, aaron.ballman

Subscribers: cfe-commits, JDevlieghere, Eugene.Zelenko

Differential Revision: https://reviews.llvm.org/D28287

llvm-svn: 290972
This commit is contained in:
Malcolm Parsons 2017-01-04 17:33:55 +00:00
parent 6cfb5caf05
commit b744ce87fc
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
View File

@ -158,7 +158,7 @@ void UseDefaultMemberInitCheck::registerMatchers(MatchFinder *Finder) {
unaryOperator(anyOf(hasOperatorName("+"), hasOperatorName("-")), unaryOperator(anyOf(hasOperatorName("+"), hasOperatorName("-")),
hasUnaryOperand(floatLiteral())), hasUnaryOperand(floatLiteral())),
cxxBoolLiteral(), cxxNullPtrLiteralExpr(), implicitValueInitExpr(), cxxBoolLiteral(), cxxNullPtrLiteralExpr(), implicitValueInitExpr(),
declRefExpr()); declRefExpr(to(enumConstantDecl())));
Finder->addMatcher( Finder->addMatcher(
cxxConstructorDecl( cxxConstructorDecl(

6
clang-tools-extra/test/clang-tidy/modernize-use-default-member-init.cpp
View File

@ -221,6 +221,12 @@ struct NegativeNotDefaultInt
int i; int i;
}; };
struct NegativeDefaultArg
{
NegativeDefaultArg(int i = 4) : i(i) {}
int i;
};
struct ExistingChar { struct ExistingChar {
ExistingChar(short) : e1(), e2(), e3(), e4() {} ExistingChar(short) : e1(), e2(), e3(), e4() {}
// CHECK-MESSAGES: :[[@LINE-1]]:25: warning: member initializer for 'e1' is redundant [modernize-use-default-member-init] // CHECK-MESSAGES: :[[@LINE-1]]:25: warning: member initializer for 'e1' is redundant [modernize-use-default-member-init]