maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Use mkdir instead of stat+mkdir. 

This is an optimistic version of create_diretories: it tries to create the
directory first and looks at the parent only if that fails.

Running strace on "mkdir -p" shows that it is pessimistic, calling mkdir on
every element of the path. We could implement that if needed.

In any case, with both strategies there is no reason to call stat, just check
the return of mkdir.

llvm-svn: 201347
This commit is contained in:
Rafael Espindola 2014-02-13 16:58:19 +00:00
parent fbe5672746
commit b6f72b240f
1 changed files with 18 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
llvm/lib/Support/Path.cpp
View File

@ -751,20 +751,27 @@ error_code make_absolute(SmallVectorImpl<char> &path) {
"occurred above!");
}
error_code create_directories(const Twine &path, bool &existed) {
SmallString<128> path_storage;
StringRef p = path.toStringRef(path_storage);
error_code create_directories(const Twine &Path, bool &Existed) {
SmallString<128> PathStorage;
StringRef P = Path.toStringRef(PathStorage);
StringRef parent = path::parent_path(p);
if (!parent.empty()) {
bool parent_exists;
if (error_code ec = fs::exists(parent, parent_exists)) return ec;
// Be optimistic and try to create the directory
error_code EC = create_directory(P, Existed);
// If we succeeded, or had any error other than the parent not existing, just
// return it.
if (EC != errc::no_such_file_or_directory)
return EC;
if (!parent_exists)
if (error_code ec = create_directories(parent, existed)) return ec;
}
// We failed because of a no_such_file_or_directory, try to create the
// parent.
StringRef Parent = path::parent_path(P);
if (Parent.empty())
return EC;
return create_directory(p, existed);
if ((EC = create_directories(Parent)))
return EC;
return create_directory(P, Existed);
}
bool exists(file_status status) {