maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Do not crash when trying to encode a _BitInt type 

Using a _BitInt (or _ExtInt) type as a block parameter or block return
type hits an "unreachable" when trying to determine the encoding for
the block. Instead of crashing, this patch handles it like some of the
other types for which we don't yet have an encoding. The test case
verifies we no longer crash, but does not verify that we provide any
particular encoding (it can be updated once someone more familiar with
ObjC steps in to define the encoding).

Fixes PR50503.
This commit is contained in:
Aaron Ballman 2022-01-28 08:37:09 -05:00
parent 2a13beaa70
commit b6d9ca14c2
2 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang/lib/AST/ASTContext.cpp
View File

@ -8290,6 +8290,11 @@ void ASTContext::getObjCEncodingForTypeImpl(QualType T, std::string &S,
*NotEncodedT = T;
return;
case Type::BitInt:
if (NotEncodedT)
*NotEncodedT = T;
return;
// We could see an undeduced auto type here during error recovery.
// Just ignore it.
case Type::Auto:
@ -8297,7 +8302,6 @@ void ASTContext::getObjCEncodingForTypeImpl(QualType T, std::string &S,
return;
case Type::Pipe:
case Type::BitInt:
#define ABSTRACT_TYPE(KIND, BASE)
#define TYPE(KIND, BASE)
#define DEPENDENT_TYPE(KIND, BASE) \

21
clang/test/CodeGenObjC/encode-test-bitint.m Normal file
View File

@ -0,0 +1,21 @@
// RUN: %clang_cc1 -triple i686-apple-darwin9 -fobjc-runtime=macosx-fragile-10.5 -fblocks -emit-llvm -o /dev/null %s
// Using a _BitInt as a block parameter or return type previously would crash
// when getting the ObjC encoding for the type. Verify that we no longer crash,
// but do not verify any particular encoding (one has not yet been determined).
void foo1(void)
{
__auto_type blk = ^int(unsigned _BitInt(64) len)
{
return 12;
};
}
void foo2(void)
{
__auto_type blk = ^unsigned _BitInt(64)(int len)
{
return 12;
};
}