maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

A constexpr virtual function is implicitly inline so should never be a 

key function.
This commit is contained in:
Richard Smith 2020-06-30 15:53:08 -07:00
parent 8b6f675f44
commit b6c490349d
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/lib/AST/RecordLayoutBuilder.cpp
View File

@ -2107,7 +2107,7 @@ static const CXXMethodDecl *computeKeyFunction(ASTContext &Context,
if (MD->isImplicit())
continue;
if (MD->isInlineSpecified())
if (MD->isInlineSpecified() || MD->isConstexpr())
continue;
if (MD->hasInlineBody())

27
clang/test/CodeGenCXX/vtable-constexpr.cpp Normal file
View File

@ -0,0 +1,27 @@
// RUN: %clang_cc1 -std=c++20 %s -emit-llvm -o - -triple %itanium_abi_triple | FileCheck %s --implicit-check-not=DoNotEmit
// constexpr virtual functions can be called at runtime and go in the vtable as
// normal. But they are implicitly inline so are never the key function.
struct DoNotEmit {
virtual constexpr void f();
};
constexpr void DoNotEmit::f() {}
// CHECK-DAG: @_ZTV1B = {{.*}} constant { [3 x i8*] } { {{.*}} null, {{.*}} @_ZTI1B {{.*}} @_ZN1B1fEv
struct B {
// CHECK-DAG: define {{.*}} @_ZN1B1fEv
virtual constexpr void f() {}
};
B b;
struct CBase {
virtual constexpr void f(); // not key function
};
// CHECK-DAG: @_ZTV1C = {{.*}} constant {{.*}} null, {{.*}} @_ZTI1C {{.*}} @_ZN1C1fEv
struct C : CBase {
void f(); // key function
};
// CHECK-DAG: define {{.*}} @_ZN1C1fEv
void C::f() {}