maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[mlir-tblgen] Stop leaking PredNodes 

Technically a leak in tblgen is harmless, but this makes asan builds of
mlir very noisy. Just use a SpecificBumpPtrAllocator that knows how to
clean up after itself.
This commit is contained in:
Benjamin Kramer 2020-02-06 18:03:15 +01:00
parent 2694cc3dca
commit b68b8be8e2
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
mlir/lib/TableGen/Predicate.cpp
View File

@ -136,10 +136,11 @@ using Subst = std::pair<StringRef, StringRef>;
// have children, and perform leaf substitutions inplace. Note that after
// substitution, nodes are still pointing to the original TableGen record.
// All nodes are created within "allocator".
static PredNode *buildPredicateTree(const tblgen::Pred &root,
llvm::BumpPtrAllocator &allocator,
ArrayRef<Subst> substitutions) {
auto *rootNode = allocator.Allocate<PredNode>();
static PredNode *
buildPredicateTree(const tblgen::Pred &root,
llvm::SpecificBumpPtrAllocator<PredNode> &allocator,
ArrayRef<Subst> substitutions) {
auto *rootNode = allocator.Allocate();
new (rootNode) PredNode;
rootNode->kind = getPredCombinerKind(root);
rootNode->predicate = &root;
@ -339,7 +340,7 @@ static std::string getCombinedCondition(const PredNode &root) {
}
std::string tblgen::CombinedPred::getConditionImpl() const {
llvm::BumpPtrAllocator allocator;
llvm::SpecificBumpPtrAllocator<PredNode> allocator;
auto predicateTree = buildPredicateTree(*this, allocator, {});
predicateTree = propagateGroundTruth(
predicateTree,