maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix for PR43175: compiler crash when trying to emit noncapturable 

constant.

If the constexpr variable is partially initialized, the initializer can
be emitted as the structure, not as an array, because of some early
optimizations. The llvm variable gets the type from this constant and,
thus, gets the type which is pointer to struct rather than pointer to an
array. We need to convert this type to be truely array, otherwise it may
lead to the compiler crash when trying to emit array subscript
expression.

llvm-svn: 371548
This commit is contained in:
Alexey Bataev 2019-09-10 19:16:56 +00:00
parent a9beacbac8
commit b5890a329a
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang/lib/CodeGen/CGExpr.cpp
View File

@ -2539,6 +2539,11 @@ LValue CodeGenFunction::EmitDeclRefLValue(const DeclRefExpr *E) {
// Spill the constant value to a global. // Spill the constant value to a global.
Addr = CGM.createUnnamedGlobalFrom(*VD, Val, Addr = CGM.createUnnamedGlobalFrom(*VD, Val,
getContext().getDeclAlign(VD)); getContext().getDeclAlign(VD));
llvm::Type *VarTy = getTypes().ConvertTypeForMem(VD->getType());
auto *PTy = llvm::PointerType::get(
VarTy, getContext().getTargetAddressSpace(VD->getType()));
if (PTy != Addr.getType())
Addr = Builder.CreatePointerBitCastOrAddrSpaceCast(Addr, PTy);
} else { } else {
// Should we be using the alignment of the constant pointer we emitted? // Should we be using the alignment of the constant pointer we emitted?
CharUnits Alignment = CharUnits Alignment =

10
clang/test/OpenMP/constexpr_partial_array.cpp Normal file
View File

@ -0,0 +1,10 @@
// RUN: %clang_cc1 -verify -triple x86_64-pc-windows-msvc19.22.27905 -emit-llvm -o - -fopenmp %s | FileCheck %s
// expected-no-diagnostics
// CHECK: [[C_VAR_VAL:@.+]] = private unnamed_addr constant <{ i8, [26 x i8] }> <{ i8 1, [26 x i8] zeroinitializer }>,
char a;
bool b() {
static constexpr bool c[27]{1};
// CHECK: getelementptr inbounds [27 x i8], [27 x i8]* bitcast (<{ i8, [26 x i8] }>* [[C_VAR_VAL]] to [27 x i8]*),
return c[a];
}