maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

ScopDetect: Make foreachs 'const auto &' 

We mostly iterate over read-only values. Following a suggestion by Duncan P.N
Exons Smith, we use the construct 'const auto &' for this.

llvm-svn: 202651
This commit is contained in:
Tobias Grosser 2014-03-02 17:05:27 +00:00
parent 45bac0d953
commit b5846f9e15
1 changed files with 8 additions and 8 deletions
polly/lib/Analysis
ScopDetection.cpp

16
polly/lib/Analysis/ScopDetection.cpp
View File

@ -332,7 +332,7 @@ std::string ScopDetection::formatInvalidAlias(AliasSet &AS) const {
std::vector<Value *> Pointers; std::vector<Value *> Pointers;
for (auto I : AS) for (const auto &I : AS)
Pointers.push_back(I.getValue()); Pointers.push_back(I.getValue());
std::sort(Pointers.begin(), Pointers.end()); std::sort(Pointers.begin(), Pointers.end());
@ -607,7 +607,7 @@ static bool regionWithoutLoops(Region &R, LoopInfo *LI) {
static unsigned eraseAllChildren(std::set<const Region *> &Regs, static unsigned eraseAllChildren(std::set<const Region *> &Regs,
const Region *R) { const Region *R) {
unsigned Count = 0; unsigned Count = 0;
for (auto SubRegion : *R) { for (const auto &SubRegion : *R) {
if (Regs.find(SubRegion) != Regs.end()) { if (Regs.find(SubRegion) != Regs.end()) {
++Count; ++Count;
Regs.erase(SubRegion); Regs.erase(SubRegion);
@ -633,7 +633,7 @@ void ScopDetection::findScops(Region &R) {
InvalidRegions[&R] = LastFailure; InvalidRegions[&R] = LastFailure;
for (auto SubRegion : R) for (const auto &SubRegion : R)
findScops(*SubRegion); findScops(*SubRegion);
// Try to expand regions. // Try to expand regions.
@ -644,10 +644,10 @@ void ScopDetection::findScops(Region &R) {
std::vector<Region *> ToExpand; std::vector<Region *> ToExpand;
for (auto SubRegion : R) for (const auto &SubRegion : R)
ToExpand.push_back(SubRegion); ToExpand.push_back(SubRegion);
for (auto CurrentRegion : ToExpand) { for (const auto &CurrentRegion : ToExpand) {
// Skip invalid regions. Regions may become invalid, if they are element of // Skip invalid regions. Regions may become invalid, if they are element of
// an already expanded region. // an already expanded region.
if (ValidRegions.find(CurrentRegion) == ValidRegions.end()) if (ValidRegions.find(CurrentRegion) == ValidRegions.end())
@ -800,7 +800,7 @@ void ScopDetection::getDebugLocation(const Region *R, unsigned &LineBegin,
} }
void ScopDetection::printLocations(llvm::Function &F) { void ScopDetection::printLocations(llvm::Function &F) {
for (auto R : *this) { for (const auto &R : *this) {
unsigned LineEntry, LineExit; unsigned LineEntry, LineExit;
std::string FileName; std::string FileName;
@ -846,7 +846,7 @@ void polly::ScopDetection::verifyAnalysis() const {
if (!VerifyScops) if (!VerifyScops)
return; return;
for (auto R : ValidRegions) for (const auto &R : ValidRegions)
verifyRegion(*R); verifyRegion(*R);
} }
@ -862,7 +862,7 @@ void ScopDetection::getAnalysisUsage(AnalysisUsage &AU) const {
} }
void ScopDetection::print(raw_ostream &OS, const Module *) const { void ScopDetection::print(raw_ostream &OS, const Module *) const {
for (auto R : ValidRegions) for (const auto &R : ValidRegions)
OS << "Valid Region for Scop: " << R->getNameStr() << '\n'; OS << "Valid Region for Scop: " << R->getNameStr() << '\n';
OS << "\n"; OS << "\n";