diff --git a/clang/include/clang/AST/Expr.h b/clang/include/clang/AST/Expr.h index 2834f6e5a0da..578dbe0a8219 100644 --- a/clang/include/clang/AST/Expr.h +++ b/clang/include/clang/AST/Expr.h @@ -868,6 +868,8 @@ public: SourceLocation getLocation() const { return Loc; } void setLocation(SourceLocation L) { Loc = L; } SourceRange getSourceRange() const; + SourceLocation getLocStart() const; + SourceLocation getLocEnd() const; /// \brief Determine whether this declaration reference was preceded by a /// C++ nested-name-specifier, e.g., \c N::foo. @@ -2392,6 +2394,8 @@ public: void setMemberLoc(SourceLocation L) { MemberLoc = L; } SourceRange getSourceRange() const; + SourceLocation getLocStart() const; + SourceLocation getLocEnd() const; SourceLocation getExprLoc() const { return MemberLoc; } @@ -2626,6 +2630,12 @@ public: SourceRange getSourceRange() const { return getSubExpr()->getSourceRange(); } + SourceLocation getLocStart() const { + return getSubExpr()->getLocStart(); + } + SourceLocation getLocEnd() const { + return getSubExpr()->getLocEnd(); + } static bool classof(const Stmt *T) { return T->getStmtClass() == ImplicitCastExprClass; diff --git a/clang/lib/AST/Expr.cpp b/clang/lib/AST/Expr.cpp index 18cc5b37bf7b..0266cd63bbc9 100644 --- a/clang/lib/AST/Expr.cpp +++ b/clang/lib/AST/Expr.cpp @@ -360,6 +360,16 @@ SourceRange DeclRefExpr::getSourceRange() const { R.setEnd(getRAngleLoc()); return R; } +SourceLocation DeclRefExpr::getLocStart() const { + if (hasQualifier()) + return getQualifierLoc().getBeginLoc(); + return getNameInfo().getLocStart(); +} +SourceLocation DeclRefExpr::getLocEnd() const { + if (hasExplicitTemplateArgs()) + return getRAngleLoc(); + return getNameInfo().getLocEnd(); +} // FIXME: Maybe this should use DeclPrinter with a special "print predefined // expr" policy instead. @@ -1016,24 +1026,26 @@ MemberExpr *MemberExpr::Create(ASTContext &C, Expr *base, bool isarrow, } SourceRange MemberExpr::getSourceRange() const { - SourceLocation StartLoc; + return SourceRange(getLocStart(), getLocEnd()); +} +SourceLocation MemberExpr::getLocStart() const { if (isImplicitAccess()) { if (hasQualifier()) - StartLoc = getQualifierLoc().getBeginLoc(); - else - StartLoc = MemberLoc; - } else { - // FIXME: We don't want this to happen. Rather, we should be able to - // detect all kinds of implicit accesses more cleanly. - StartLoc = getBase()->getLocStart(); - if (StartLoc.isInvalid()) - StartLoc = MemberLoc; + return getQualifierLoc().getBeginLoc(); + return MemberLoc; } - SourceLocation EndLoc = hasExplicitTemplateArgs() - ? getRAngleLoc() : getMemberNameInfo().getEndLoc(); - - return SourceRange(StartLoc, EndLoc); + // FIXME: We don't want this to happen. Rather, we should be able to + // detect all kinds of implicit accesses more cleanly. + SourceLocation BaseStartLoc = getBase()->getLocStart(); + if (BaseStartLoc.isValid()) + return BaseStartLoc; + return MemberLoc; +} +SourceLocation MemberExpr::getLocEnd() const { + if (hasExplicitTemplateArgs()) + return getRAngleLoc(); + return getMemberNameInfo().getEndLoc(); } void CastExpr::CheckCastConsistency() const {