maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[LCG] Switch the primary SCC building code to use the negative low-link 

values rather than an expensive dense map query to test whether children
have already been popped into an SCC. This matches the incremental SCC
building code. I've also included the assert that I put there but
updated both of their text.

No functionality changed here.

I still don't have any great ideas for sharing the code between the two
implementations, but I may try a brute-force approach to factoring it at
some point.

llvm-svn: 207042
This commit is contained in:
Chandler Carruth 2014-04-23 22:28:13 +00:00
parent 885a33a0a3
commit b4a04da0b9
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/lib/Analysis/LazyCallGraph.cpp
View File

@ -260,7 +260,7 @@ LazyCallGraph::SCC::removeInternalEdge(LazyCallGraph &G, Node &Caller,
// Track the lowest link of the childen, if any are still in the stack.
// Any child not on the stack will have a LowLink of -1.
assert(ChildN->LowLink != 0 &&
"Impossible with a non-zero DFS number.");
"Low-link must not be zero with a non-zero DFS number.");
if (ChildN->LowLink >= 0 && ChildN->LowLink < N->LowLink)
N->LowLink = ChildN->LowLink;
}
@ -465,7 +465,9 @@ LazyCallGraph::SCC *LazyCallGraph::getNextSCCInPostOrder() {
}
// Track the lowest link of the childen, if any are still in the stack.
if (ChildN->LowLink < N->LowLink && !SCCMap.count(&ChildN->getFunction()))
assert(ChildN->LowLink != 0 &&
"Low-link must not be zero with a non-zero DFS number.");
if (ChildN->LowLink >= 0 && ChildN->LowLink < N->LowLink)
N->LowLink = ChildN->LowLink;
}
// No more children to process for this stack entry.