maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Sema: partially address post-commit comments 

Un-parameterize the warning as there is exactly one attribute added in C++14.
Partially addresses post-commit review comments from Richard Smith.

llvm-svn: 229636
This commit is contained in:
Saleem Abdulrasool 2015-02-18 04:33:26 +00:00
parent 6d86bb2f8b
commit b47d606e17
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clang/include/clang/Basic/DiagnosticSemaKinds.td
View File

@ -7233,8 +7233,8 @@ def err_asm_naked_this_ref : Error<
def err_asm_naked_parm_ref : Error<
"parameter references not allowed in naked functions">;
def ext_use_of_attribute_is_a_cxx14_extension : ExtWarn<
"use of the %0 attribute is a C++14 extension">, InGroup<CXX14>;
def ext_deprecated_attr_is_a_cxx14_extension : ExtWarn<
"use of the 'deprecated' attribute is a C++14 extension">, InGroup<CXX14>;
// OpenCL warnings and errors.
def err_invalid_astype_of_different_size : Error<

3
clang/lib/Sema/SemaDeclAttr.cpp
View File

@ -4258,8 +4258,7 @@ static void handleDeprecatedAttr(Sema &S, Decl *D, const AttributeList &Attr) {
if (!S.getLangOpts().CPlusPlus14)
if (Attr.isCXX11Attribute() &&
!(Attr.hasScope() && Attr.getScopeName()->isStr("gnu")))
S.Diag(Attr.getLoc(), diag::ext_use_of_attribute_is_a_cxx14_extension)
<< Attr.getName();
S.Diag(Attr.getLoc(), diag::ext_deprecated_attr_is_a_cxx14_extension);
handleAttrWithMessage<DeprecatedAttr>(S, D, Attr);
}