maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[libc++][test] Fix infinite loop when mkstemp fails 

mkstemp is guaranteed to make at least TMP_MAX attempts to create the
random file, and if it can't, it fails with EEXIST. get_temp_file_name
shouldn't call mkstemp again if it fails with anything other than
EEXIST. A single mkstemp call seems sufficient.

On Android, I've seen mkstemp fail with:
 - EROFS (because cwd wasn't set to a writable filesystem)
 - EACCES (because cwd pointed to a dir owned by root, but the test
   program was running as the shell user instead)

Previously, get_temp_file_name would run forever in these situations.

See D4962 and "llvm-svn: 229035"

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D130214
This commit is contained in:
Ryan Prichard 2022-07-22 16:20:47 -07:00
parent 589ddd7fe8
commit b4722cc4c9
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
libcxx/test/support/platform_support.h
View File

@ -75,16 +75,12 @@ std::string get_temp_file_name()
abort();
}
#else
std::string Name;
int FD = -1;
do {
Name = "libcxx.XXXXXX";
FD = mkstemp(&Name[0]);
if (FD == -1 && errno == EINVAL) {
perror("mkstemp");
abort();
}
} while (FD == -1);
std::string Name = "libcxx.XXXXXX";
int FD = mkstemp(&Name[0]);
if (FD == -1) {
perror("mkstemp");
abort();
}
close(FD);
return Name;
#endif