maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Dsymutil] Remove redundant argument (NFC) 

The dwarf streamer already holds a copy of the link options, so there's
no need to pass them as an argument.

llvm-svn: 361276
This commit is contained in:
Jonas Devlieghere 2019-05-21 17:31:51 +00:00
parent fb2a076511
commit b43dfaa6c0
3 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/tools/dsymutil/DwarfLinker.cpp
View File

@ -626,7 +626,7 @@ unsigned DwarfLinker::shouldKeepVariableDIE(RelocationManager &RelocMgr,
MyInfo.InDebugMap = true; MyInfo.InDebugMap = true;
return Flags | TF_Keep; return Flags | TF_Keep;
} }
Optional<uint32_t> LocationIdx = Optional<uint32_t> LocationIdx =
Abbrev->findAttributeIndex(dwarf::DW_AT_location); Abbrev->findAttributeIndex(dwarf::DW_AT_location);
if (!LocationIdx) if (!LocationIdx)
@ -1820,7 +1820,7 @@ void DwarfLinker::patchLineTableForUnit(CompileUnit &Unit,
OrigDwarf.getDWARFObj(), OrigDwarf.getDWARFObj().getLineSection(), OrigDwarf.getDWARFObj(), OrigDwarf.getDWARFObj().getLineSection(),
OrigDwarf.isLittleEndian(), Unit.getOrigUnit().getAddressByteSize()); OrigDwarf.isLittleEndian(), Unit.getOrigUnit().getAddressByteSize());
if (Options.Translator) if (Options.Translator)
return Streamer->translateLineTable(LineExtractor, StmtOffset, Options); return Streamer->translateLineTable(LineExtractor, StmtOffset);
Error Err = LineTable.parse(LineExtractor, &StmtOffset, OrigDwarf, Error Err = LineTable.parse(LineExtractor, &StmtOffset, OrigDwarf,
&Unit.getOrigUnit(), DWARFContext::dumpWarning); &Unit.getOrigUnit(), DWARFContext::dumpWarning);
@ -2845,7 +2845,7 @@ bool DwarfLinker::link(const DebugMap &Map) {
copySwiftInterfaces(ParseableSwiftInterfaces, ArchName, Options)) copySwiftInterfaces(ParseableSwiftInterfaces, ArchName, Options))
return error(toString(std::move(E))); return error(toString(std::move(E)));
} }
return Streamer->finish(Map, Options.Translator); return Streamer->finish(Map, Options.Translator);
} // namespace dsymutil } // namespace dsymutil

3
llvm/tools/dsymutil/DwarfStreamer.cpp
View File

@ -584,8 +584,7 @@ void DwarfStreamer::emitLineTableForUnit(MCDwarfLineTableParams Params,
/// Copy the debug_line over to the updated binary while unobfuscating the file /// Copy the debug_line over to the updated binary while unobfuscating the file
/// names and directories. /// names and directories.
void DwarfStreamer::translateLineTable(DataExtractor Data, uint32_t Offset, void DwarfStreamer::translateLineTable(DataExtractor Data, uint32_t Offset) {
LinkOptions &Options) {
MS->SwitchSection(MC->getObjectFileInfo()->getDwarfLineSection()); MS->SwitchSection(MC->getObjectFileInfo()->getDwarfLineSection());
StringRef Contents = Data.getData(); StringRef Contents = Data.getData();

3
llvm/tools/dsymutil/DwarfStreamer.h
View File

@ -107,8 +107,7 @@ public:
/// Copy the debug_line over to the updated binary while unobfuscating the /// Copy the debug_line over to the updated binary while unobfuscating the
/// file names and directories. /// file names and directories.
void translateLineTable(DataExtractor LineData, uint32_t Offset, void translateLineTable(DataExtractor LineData, uint32_t Offset);
LinkOptions &Options);
/// Copy over the debug sections that are not modified when updating. /// Copy over the debug sections that are not modified when updating.
void copyInvariantDebugSection(const object::ObjectFile &Obj); void copyInvariantDebugSection(const object::ObjectFile &Obj);