AsmParser: Don't crash on malformed attribute groups

This fixes PR21785. llvm-svn: 223801
2014-12-09 18:33:57 +00:00 · 2014-12-09 18:33:57 +00:00 · b39e22bdc5
parent 30dcb232b0
commit b39e22bdc5
2 changed files with 7 additions and 1 deletions
--- a/llvm/lib/AsmParser/LLParser.cpp
+++ b/llvm/lib/AsmParser/LLParser.cpp
@ -869,7 +869,9 @@ bool LLParser::ParseUnnamedAttrGrp() {
  LocTy AttrGrpLoc = Lex.getLoc();
  Lex.Lex();

-  assert(Lex.getKind() == lltok::AttrGrpID);
+  if (Lex.getKind() != lltok::AttrGrpID)
+    return TokError("expected attribute group id");
+
  unsigned VarID = Lex.getUIntVal();
  std::vector<unsigned> unused;
  LocTy BuiltinLoc;
--- a/llvm/test/Assembler/invalid-attrgrp.ll
+++ b/llvm/test/Assembler/invalid-attrgrp.ll
@ -0,0 +1,4 @@
+; RUN: not llvm-as < %s 2>&1 | FileCheck %s
+
+attributes
+; CHECK: expected attribute group id