forked from OSchip/llvm-project
[ConstantRange] binaryXor(): special-case binary complement case - the result is precise
Use the fact that `~X` is equivalent to `-1 - X`, which gives us fully-precise answer, and we only need to special-handle the wrapped case. This fires ~16k times for vanilla llvm test-suite + RawSpeed.
This commit is contained in:
parent
4eeeb356fc
commit
b38d897e80
|
@ -409,6 +409,11 @@ public:
|
|||
/// value in \p Other.
|
||||
ConstantRange srem(const ConstantRange &Other) const;
|
||||
|
||||
/// Return a new range representing the possible values resulting from
|
||||
/// a binary-xor of a value in this range by an all-one value,
|
||||
/// aka bitwise complement operation.
|
||||
ConstantRange binaryNot() const;
|
||||
|
||||
/// Return a new range representing the possible values resulting
|
||||
/// from a binary-and of a value in this range by a value in \p Other.
|
||||
ConstantRange binaryAnd(const ConstantRange &Other) const;
|
||||
|
|
|
@ -1240,6 +1240,16 @@ ConstantRange ConstantRange::srem(const ConstantRange &RHS) const {
|
|||
return ConstantRange(std::move(Lower), std::move(Upper));
|
||||
}
|
||||
|
||||
ConstantRange ConstantRange::binaryNot() const {
|
||||
if (isEmptySet())
|
||||
return getEmpty();
|
||||
|
||||
if (isWrappedSet())
|
||||
return getFull();
|
||||
|
||||
return ConstantRange(APInt::getAllOnesValue(getBitWidth())).sub(*this);
|
||||
}
|
||||
|
||||
ConstantRange
|
||||
ConstantRange::binaryAnd(const ConstantRange &Other) const {
|
||||
if (isEmptySet() || Other.isEmptySet())
|
||||
|
@ -1278,6 +1288,12 @@ ConstantRange ConstantRange::binaryXor(const ConstantRange &Other) const {
|
|||
if (isSingleElement() && Other.isSingleElement())
|
||||
return {*getSingleElement() ^ *Other.getSingleElement()};
|
||||
|
||||
// Special-case binary complement, since we can give a precise answer.
|
||||
if (Other.isSingleElement() && Other.getSingleElement()->isAllOnesValue())
|
||||
return binaryNot();
|
||||
if (isSingleElement() && getSingleElement()->isAllOnesValue())
|
||||
return Other.binaryNot();
|
||||
|
||||
// TODO: replace this with something less conservative
|
||||
return getFull();
|
||||
}
|
||||
|
|
|
@ -2349,4 +2349,22 @@ TEST_F(ConstantRangeTest, binaryXor) {
|
|||
EXPECT_TRUE(R0_99.binaryXor(R16_35).isFullSet());
|
||||
}
|
||||
|
||||
TEST_F(ConstantRangeTest, binaryNot) {
|
||||
TestUnsignedUnaryOpExhaustive(
|
||||
[](const ConstantRange &CR) { return CR.binaryNot(); },
|
||||
[](const APInt &N) { return ~N; });
|
||||
TestUnsignedUnaryOpExhaustive(
|
||||
[](const ConstantRange &CR) {
|
||||
return CR.binaryXor(
|
||||
ConstantRange(APInt::getAllOnesValue(CR.getBitWidth())));
|
||||
},
|
||||
[](const APInt &N) { return ~N; });
|
||||
TestUnsignedUnaryOpExhaustive(
|
||||
[](const ConstantRange &CR) {
|
||||
return ConstantRange(APInt::getAllOnesValue(CR.getBitWidth()))
|
||||
.binaryXor(CR);
|
||||
},
|
||||
[](const APInt &N) { return ~N; });
|
||||
}
|
||||
|
||||
} // anonymous namespace
|
||||
|
|
Loading…
Reference in New Issue