maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Remove redundant test in TestExitDuringStep 

After recent changes, test_thread_state_is_stopped has become equivalent to test_step_in, as the
function exit_during_step_base was not using the "test_thread_state" parameter. As test was
XFAILed on all platforms anyway, and we have other tests for the bug which it (used to) test, I
am simply removing the function.

llvm-svn: 259517
This commit is contained in:
Pavel Labath 2016-02-02 15:58:30 +00:00
parent 0df1b0bf42
commit b32b19cde1
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lldb/packages/Python/lldbsuite/test/functionalities/thread/exit_during_step/TestExitDuringStep.py
View File

@ -15,34 +15,26 @@ class ExitDuringStepTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__) mydir = TestBase.compute_mydir(__file__)
@expectedFailureDarwin("llvm.org/pr15824") # thread states not properly maintained
@expectedFailureFreeBSD("llvm.org/pr18190") # thread states not properly maintained
@expectedFailureLinux("llvm.org/pr15824") # thread states not properly maintained
def test_thread_state_is_stopped(self):
"""Test thread exit during step handling."""
self.build(dictionary=self.getBuildFlags())
self.exit_during_step_base("thread step-in -m all-threads", 'stop reason = step in', True)
@skipIfFreeBSD # llvm.org/pr21411: test is hanging @skipIfFreeBSD # llvm.org/pr21411: test is hanging
@expectedFlakeyAndroid("llvm.org/pr26206") @expectedFlakeyAndroid("llvm.org/pr26206")
def test(self): def test(self):
"""Test thread exit during step handling.""" """Test thread exit during step handling."""
self.build(dictionary=self.getBuildFlags()) self.build(dictionary=self.getBuildFlags())
self.exit_during_step_base("thread step-inst -m all-threads", 'stop reason = instruction step', False) self.exit_during_step_base("thread step-inst -m all-threads", 'stop reason = instruction step')
@skipIfFreeBSD # llvm.org/pr21411: test is hanging @skipIfFreeBSD # llvm.org/pr21411: test is hanging
@expectedFlakeyAndroid("llvm.org/pr26206") @expectedFlakeyAndroid("llvm.org/pr26206")
def test_step_over(self): def test_step_over(self):
"""Test thread exit during step-over handling.""" """Test thread exit during step-over handling."""
self.build(dictionary=self.getBuildFlags()) self.build(dictionary=self.getBuildFlags())
self.exit_during_step_base("thread step-over -m all-threads", 'stop reason = step over', False) self.exit_during_step_base("thread step-over -m all-threads", 'stop reason = step over')
@skipIfFreeBSD # llvm.org/pr21411: test is hanging @skipIfFreeBSD # llvm.org/pr21411: test is hanging
@expectedFlakeyAndroid("llvm.org/pr26206") @expectedFlakeyAndroid("llvm.org/pr26206")
def test_step_in(self): def test_step_in(self):
"""Test thread exit during step-in handling.""" """Test thread exit during step-in handling."""
self.build(dictionary=self.getBuildFlags()) self.build(dictionary=self.getBuildFlags())
self.exit_during_step_base("thread step-in -m all-threads", 'stop reason = step in', False) self.exit_during_step_base("thread step-in -m all-threads", 'stop reason = step in')
def setUp(self): def setUp(self):
# Call super's setUp(). # Call super's setUp().
@ -51,7 +43,7 @@ class ExitDuringStepTestCase(TestBase):
self.breakpoint = line_number('main.cpp', '// Set breakpoint here') self.breakpoint = line_number('main.cpp', '// Set breakpoint here')
self.continuepoint = line_number('main.cpp', '// Continue from here') self.continuepoint = line_number('main.cpp', '// Continue from here')
def exit_during_step_base(self, step_cmd, step_stop_reason, test_thread_state): def exit_during_step_base(self, step_cmd, step_stop_reason):
"""Test thread exit during step handling.""" """Test thread exit during step handling."""
exe = os.path.join(os.getcwd(), "a.out") exe = os.path.join(os.getcwd(), "a.out")
self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET) self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)