maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Reinstate check that we don't crash.

This commit is contained in:
Richard Smith 2020-08-06 19:07:50 -07:00
parent 2f1fffab73
commit b2847671b8
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp
View File

@ -794,16 +794,16 @@ struct Bar {
}
};
// FIXME: It's not clear that we should be diagnosing this. The `&&` operator
// here is unresolved and could resolve to an overloaded operator that might
// have side-effects on its operands. For other constructs with the same
// property (eg, the `S2` cases above) we suppress this diagnostic. This
// started failing when Clang started properly modeling the fold-expression as
// containing an unresolved operator name.
//template <class... Values>
//struct Bar2 {
// static_assert((... && (sizeof(Values) > 0)) == (... && (sizeof(Values) > 0)));
// // -MESSAGES: :[[@LINE-1]]:47: warning: both sides of operator are equivalent [misc-redundant-expression]
//};
template <class... Values>
struct Bar2 {
static_assert((... && (sizeof(Values) > 0)) == (... && (sizeof(Values) > 0)));
// FIXME: It's not clear that we should be diagnosing this. The `&&` operator
// here is unresolved and could resolve to an overloaded operator that might
// have side-effects on its operands. For other constructs with the same
// property (eg, the `S2` cases above) we suppress this diagnostic. This
// started failing when Clang started properly modeling the fold-expression as
// containing an unresolved operator name.
// FIXME-MESSAGES: :[[@LINE-1]]:47: warning: both sides of operator are equivalent [misc-redundant-expression]
};
} // namespace no_crash