From b2144058a64b4287b76c2cd3d403ad5b5513d64d Mon Sep 17 00:00:00 2001
From: Sam Clegg <sbc@chromium.org>
Date: Mon, 2 Jul 2018 21:01:43 +0000
Subject: [PATCH] [LTO] Errors in LLVM backend should manifest as lld errors

Differential Revision: https://reviews.llvm.org/D48812

llvm-svn: 336143
---
 lld/Common/ErrorHandler.cpp                 | 13 +++++++++++-
 lld/test/ELF/lto/Inputs/sample-profile.prof |  1 +
 lld/test/ELF/lto/sample-profile.ll          |  4 ++--
 lld/test/wasm/lto/diagnostics.ll            | 22 +++++++++++++++++++++
 4 files changed, 37 insertions(+), 3 deletions(-)
 create mode 100644 lld/test/ELF/lto/Inputs/sample-profile.prof
 create mode 100644 lld/test/wasm/lto/diagnostics.ll

diff --git a/lld/Common/ErrorHandler.cpp b/lld/Common/ErrorHandler.cpp
index 6dacc2c850bc..d1cb3dbbe03c 100644
--- a/lld/Common/ErrorHandler.cpp
+++ b/lld/Common/ErrorHandler.cpp
@@ -65,7 +65,18 @@ void lld::diagnosticHandler(const DiagnosticInfo &DI) {
   raw_svector_ostream OS(S);
   DiagnosticPrinterRawOStream DP(OS);
   DI.print(DP);
-  warn(S);
+  switch (DI.getSeverity()) {
+  case DS_Error:
+    error(S);
+    break;
+  case DS_Warning:
+    warn(S);
+    break;
+  case DS_Remark:
+  case DS_Note:
+    message(S);
+    break;
+  }
 }
 
 void lld::checkError(Error E) {
diff --git a/lld/test/ELF/lto/Inputs/sample-profile.prof b/lld/test/ELF/lto/Inputs/sample-profile.prof
new file mode 100644
index 000000000000..0ccd747bd376
--- /dev/null
+++ b/lld/test/ELF/lto/Inputs/sample-profile.prof
@@ -0,0 +1 @@
+f:0:0
diff --git a/lld/test/ELF/lto/sample-profile.ll b/lld/test/ELF/lto/sample-profile.ll
index 17eead752de4..a8b110444425 100644
--- a/lld/test/ELF/lto/sample-profile.ll
+++ b/lld/test/ELF/lto/sample-profile.ll
@@ -3,11 +3,11 @@
 ; RUN: opt -module-summary %p/Inputs/thinlto.ll -o %t2.o
 
 ; RUN: rm -f %t1.lto.o %t2.lto.o
-; RUN: ld.lld --lto-sample-profile=/dev/null %t1.o %t2.o -o %t3
+; RUN: ld.lld --lto-sample-profile=%p/Inputs/sample-profile.prof %t1.o %t2.o -o %t3
 ; RUN  opt -S %t3.lto.o | FileCheck %s
 
 ; RUN: rm -f %t1.lto.o %t2.lto.o
-; RUN: ld.lld --plugin-opt=sample-profile=/dev/null %t1.o %t2.o -o %t3
+; RUN: ld.lld --plugin-opt=sample-profile=%p/Inputs/sample-profile.prof %t1.o %t2.o -o %t3
 ; RUN  opt -S %t3.lto.o | FileCheck %s
 
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
diff --git a/lld/test/wasm/lto/diagnostics.ll b/lld/test/wasm/lto/diagnostics.ll
new file mode 100644
index 000000000000..77f68fe93abb
--- /dev/null
+++ b/lld/test/wasm/lto/diagnostics.ll
@@ -0,0 +1,22 @@
+; verify that errors in the LLVM backend during LTO manifest as lld
+; errors
+
+; RUN: llvm-as %s -o %t.o
+; RUN: not wasm-ld --lto-O0 %t.o -o %t2 2>&1 | FileCheck %s
+
+target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
+target triple = "wasm32-unknown-unknown"
+
+define void @_start() {
+  call i8* @foo()
+  ret void
+}
+
+define i8* @foo() {
+  %1 = call i8* @llvm.returnaddress(i32 0)
+  ret i8* %1
+}
+
+declare i8* @llvm.returnaddress(i32)
+
+; CHECK: error: {{.*}} WebAssembly hasn't implemented __builtin_return_address