maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[InstCombine] Reduce code duplication in GEP of PHI transform; NFC 

The `NewGEP->setOperand(DI, NewPN)` call was duplicated, and the
insertion of NewGEP is the same in both if/else, so we can extract it.
This commit is contained in:
Nikita Popov 2020-03-28 18:44:35 +01:00
parent e8743c0f38
commit b1f78baeaa
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
View File

@ -1975,8 +1975,6 @@ Instruction *InstCombiner::visitGetElementPtrInst(GetElementPtrInst &GEP) {
if (DI == -1) { if (DI == -1) {
// All the GEPs feeding the PHI are identical. Clone one down into our // All the GEPs feeding the PHI are identical. Clone one down into our
// BB so that it can be merged with the current GEP. // BB so that it can be merged with the current GEP.
GEP.getParent()->getInstList().insert(
GEP.getParent()->getFirstInsertionPt(), NewGEP);
} else { } else {
// All the GEPs feeding the PHI differ at a single offset. Clone a GEP // All the GEPs feeding the PHI differ at a single offset. Clone a GEP
// into the current block so it can be merged, and create a new PHI to // into the current block so it can be merged, and create a new PHI to
@ -1994,11 +1992,10 @@ Instruction *InstCombiner::visitGetElementPtrInst(GetElementPtrInst &GEP) {
PN->getIncomingBlock(I)); PN->getIncomingBlock(I));
NewGEP->setOperand(DI, NewPN); NewGEP->setOperand(DI, NewPN);
GEP.getParent()->getInstList().insert(
GEP.getParent()->getFirstInsertionPt(), NewGEP);
NewGEP->setOperand(DI, NewPN);
} }
GEP.getParent()->getInstList().insert(
GEP.getParent()->getFirstInsertionPt(), NewGEP);
GEP.setOperand(0, NewGEP); GEP.setOperand(0, NewGEP);
PtrOp = NewGEP; PtrOp = NewGEP;
} }