From b1bcd5dc7b875e0cdd33573c1736010b35880a14 Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Sat, 11 Jun 2016 04:45:38 +0000 Subject: [PATCH] Revert "[ASTMatchers] New forEachOverriden matcher." This reverts commit r272386. It doesn't compile with MSVC and those bots have been red the entire day as a consequence. llvm-svn: 272453 --- clang/docs/LibASTMatchersReference.html | 24 ---------- clang/include/clang/AST/ASTContext.h | 3 -- clang/include/clang/AST/DeclCXX.h | 3 -- clang/include/clang/ASTMatchers/ASTMatchers.h | 41 ----------------- clang/lib/AST/ASTContext.cpp | 21 ++++----- clang/lib/AST/DeclCXX.cpp | 7 --- .../ASTMatchers/ASTMatchersTraversalTest.cpp | 44 ------------------- 7 files changed, 9 insertions(+), 134 deletions(-) diff --git a/clang/docs/LibASTMatchersReference.html b/clang/docs/LibASTMatchersReference.html index 5ab355689072..3606367d2fde 100644 --- a/clang/docs/LibASTMatchersReference.html +++ b/clang/docs/LibASTMatchersReference.html @@ -3968,30 +3968,6 @@ matcher, or is a pointer to a type that matches the InnerMatcher. -Matcher<CXXMethodDecl>forEachOverriddenMatcher<CXXMethodDecl> InnerMatcher -
Matches each method overriden by the given method. This matcher may
-produce multiple matches.
-
-Given
-  class A { virtual void f(); };
-  class B : public A { void f(); };
-  class C : public B { void f(); };
-cxxMethodDecl(ofClass(hasName("C")),
-              forEachOverridden(cxxMethodDecl().bind("b"))).bind("d")
-  matches once, with "b" binding "A::f" and "d" binding "C::f" (Note
-  that B::f is not overridden by C::f).
-
-The check can produce multiple matches in case of multiple inheritance, e.g.
-  class A1 { virtual void f(); };
-  class A2 { virtual void f(); };
-  class C : public A1, public A2 { void f(); };
-cxxMethodDecl(ofClass(hasName("C")),
-              forEachOverridden(cxxMethodDecl().bind("b"))).bind("d")
-  matches twice, once with "b" binding "A1::f" and "d" binding "C::f", and
-  once with "b" binding "A2::f" and "d" binding "C::f".
-
- - Matcher<CXXMethodDecl>ofClassMatcher<CXXRecordDecl> InnerMatcher 
Matches the class declaration that the given method declaration
 belongs to.
diff --git a/clang/include/clang/AST/ASTContext.h b/clang/include/clang/AST/ASTContext.h
index e3fc46434455..47f89c636130 100644
--- a/clang/include/clang/AST/ASTContext.h
+++ b/clang/include/clang/AST/ASTContext.h
@@ -821,9 +821,6 @@ public:
   overridden_methods_end(const CXXMethodDecl *Method) const;
 
   unsigned overridden_methods_size(const CXXMethodDecl *Method) const;
-  typedef llvm::iterator_range
-      overridden_method_range;
-  overridden_method_range overridden_methods(const CXXMethodDecl *Method) const;
 
   /// \brief Note that the given C++ \p Method overrides the given \p
   /// Overridden method.
diff --git a/clang/include/clang/AST/DeclCXX.h b/clang/include/clang/AST/DeclCXX.h
index e540f072e133..755542c04a17 100644
--- a/clang/include/clang/AST/DeclCXX.h
+++ b/clang/include/clang/AST/DeclCXX.h
@@ -16,7 +16,6 @@
 #ifndef LLVM_CLANG_AST_DECLCXX_H
 #define LLVM_CLANG_AST_DECLCXX_H
 
-#include "clang/AST/ASTContext.h"
 #include "clang/AST/ASTUnresolvedSet.h"
 #include "clang/AST/Attr.h"
 #include "clang/AST/Decl.h"
@@ -1829,8 +1828,6 @@ public:
   method_iterator begin_overridden_methods() const;
   method_iterator end_overridden_methods() const;
   unsigned size_overridden_methods() const;
-  typedef ASTContext::overridden_method_range overridden_method_range;
-  overridden_method_range overridden_methods() const;
 
   /// Returns the parent of this method declaration, which
   /// is the class in which this method is defined.
diff --git a/clang/include/clang/ASTMatchers/ASTMatchers.h b/clang/include/clang/ASTMatchers/ASTMatchers.h
index 778b993bc83b..712eef0d3ca9 100644
--- a/clang/include/clang/ASTMatchers/ASTMatchers.h
+++ b/clang/include/clang/ASTMatchers/ASTMatchers.h
@@ -3770,47 +3770,6 @@ AST_MATCHER_P(CXXMethodDecl, ofClass,
           InnerMatcher.matches(*Parent, Finder, Builder));
 }
 
-/// \brief Matches each method overriden by the given method. This matcher may
-/// produce multiple matches.
-///
-/// Given
-/// \code
-///   class A { virtual void f(); };
-///   class B : public A { void f(); };
-///   class C : public B { void f(); };
-/// \endcode
-/// cxxMethodDecl(ofClass(hasName("C")),
-///               forEachOverridden(cxxMethodDecl().bind("b"))).bind("d")
-///   matches once, with "b" binding "A::f" and "d" binding "C::f" (Note
-///   that B::f is not overridden by C::f).
-///
-/// The check can produce multiple matches in case of multiple inheritance, e.g.
-/// \code
-///   class A1 { virtual void f(); };
-///   class A2 { virtual void f(); };
-///   class C : public A1, public A2 { void f(); };
-/// \endcode
-/// cxxMethodDecl(ofClass(hasName("C")),
-///               forEachOverridden(cxxMethodDecl().bind("b"))).bind("d")
-///   matches twice, once with "b" binding "A1::f" and "d" binding "C::f", and
-///   once with "b" binding "A2::f" and "d" binding "C::f".
-AST_MATCHER_P(CXXMethodDecl, forEachOverridden,
-              internal::Matcher, InnerMatcher) {
-  BoundNodesTreeBuilder Result;
-  bool Matched = false;
-  for (const auto *Overridden : Node.overridden_methods()) {
-    BoundNodesTreeBuilder OverriddenBuilder(*Builder);
-    const bool OverriddenMatched =
-        InnerMatcher.matches(*Overridden, Finder, &OverriddenBuilder);
-    if (OverriddenMatched) {
-      Matched = true;
-      Result.addMatch(OverriddenBuilder);
-    }
-  }
-  *Builder = std::move(Result);
-  return Matched;
-}
-
 /// \brief Matches if the given method declaration is virtual.
 ///
 /// Given
diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp
index 67024e7c3910..fa46b24e57c9 100644
--- a/clang/lib/AST/ASTContext.cpp
+++ b/clang/lib/AST/ASTContext.cpp
@@ -1254,35 +1254,32 @@ void ASTContext::setInstantiatedFromUnnamedFieldDecl(FieldDecl *Inst,
 
 ASTContext::overridden_cxx_method_iterator
 ASTContext::overridden_methods_begin(const CXXMethodDecl *Method) const {
-  llvm::DenseMap::const_iterator Pos =
-      OverriddenMethods.find(Method->getCanonicalDecl());
+  llvm::DenseMap::const_iterator Pos
+    = OverriddenMethods.find(Method->getCanonicalDecl());
   if (Pos == OverriddenMethods.end())
     return nullptr;
+
   return Pos->second.begin();
 }
 
 ASTContext::overridden_cxx_method_iterator
 ASTContext::overridden_methods_end(const CXXMethodDecl *Method) const {
-  llvm::DenseMap::const_iterator Pos =
-      OverriddenMethods.find(Method->getCanonicalDecl());
+  llvm::DenseMap::const_iterator Pos
+    = OverriddenMethods.find(Method->getCanonicalDecl());
   if (Pos == OverriddenMethods.end())
     return nullptr;
+
   return Pos->second.end();
 }
 
 unsigned
 ASTContext::overridden_methods_size(const CXXMethodDecl *Method) const {
-  llvm::DenseMap::const_iterator Pos =
-      OverriddenMethods.find(Method->getCanonicalDecl());
+  llvm::DenseMap::const_iterator Pos
+    = OverriddenMethods.find(Method->getCanonicalDecl());
   if (Pos == OverriddenMethods.end())
     return 0;
-  return Pos->second.size();
-}
 
-ASTContext::overridden_method_range
-ASTContext::overridden_methods(const CXXMethodDecl *Method) const {
-  return overridden_method_range(overridden_methods_begin(Method),
-                                 overridden_methods_end(Method));
+  return Pos->second.size();
 }
 
 void ASTContext::addOverriddenMethod(const CXXMethodDecl *Method, 
diff --git a/clang/lib/AST/DeclCXX.cpp b/clang/lib/AST/DeclCXX.cpp
index 83c7db88f4d9..2a1fac8509eb 100644
--- a/clang/lib/AST/DeclCXX.cpp
+++ b/clang/lib/AST/DeclCXX.cpp
@@ -1635,13 +1635,6 @@ unsigned CXXMethodDecl::size_overridden_methods() const {
   return getASTContext().overridden_methods_size(this);
 }
 
-CXXMethodDecl::overridden_method_range
-CXXMethodDecl::overridden_methods() const {
-  if (isa(this))
-    return overridden_method_range(nullptr, nullptr);
-  return getASTContext().overridden_methods(this);
-}
-
 QualType CXXMethodDecl::getThisType(ASTContext &C) const {
   // C++ 9.3.2p1: The type of this in a member function of a class X is X*.
   // If the member function is declared const, the type of this is const X*,
diff --git a/clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp b/clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp
index aa861f4e4da0..cc5cf715a706 100644
--- a/clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp
+++ b/clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp
@@ -1997,49 +1997,5 @@ TEST(StatementMatcher, ForFunction) {
   EXPECT_TRUE(notMatches(CppString2, returnStmt(forFunction(hasName("F")))));
 }
 
-TEST(Matcher, ForEachOverriden) {
-  const auto ForEachOverriddenInClass = [](const char *ClassName) {
-    return cxxMethodDecl(ofClass(hasName(ClassName)), isVirtual(),
-                         forEachOverridden(cxxMethodDecl().bind("overridden")))
-        .bind("override");
-  };
-  constexpr const char Code1[] = "class A { virtual void f(); };"
-                                 "class B : public A { void f(); };"
-                                 "class C : public B { void f(); };";
-  // C::f overrides A::f.
-  EXPECT_TRUE(matchAndVerifyResultTrue(
-      Code1, ForEachOverriddenInClass("C"),
-      llvm::make_unique>("override", "f", 1)));
-  EXPECT_TRUE(matchAndVerifyResultTrue(
-      Code1, ForEachOverriddenInClass("C"),
-      llvm::make_unique>("overridden", "f",
-                                                          1)));
-  // B::f overrides A::f.
-  EXPECT_TRUE(matchAndVerifyResultTrue(
-      Code1, ForEachOverriddenInClass("B"),
-      llvm::make_unique>("override", "f", 1)));
-  EXPECT_TRUE(matchAndVerifyResultTrue(
-      Code1, ForEachOverriddenInClass("B"),
-      llvm::make_unique>("overridden", "f",
-                                                          1)));
-  // A::f overrides nothing.
-  EXPECT_TRUE(notMatches(Code1, ForEachOverriddenInClass("A")));
-
-  constexpr const char Code2[] =
-      "class A1 { virtual void f(); };"
-      "class A2 { virtual void f(); };"
-      "class B : public A1, public A2 { void f(); };";
-  // B::f overrides A1::f and A2::f. This produces two matches.
-  EXPECT_TRUE(matchAndVerifyResultTrue(
-      Code2, ForEachOverriddenInClass("B"),
-      llvm::make_unique>("override", "f", 2)));
-  EXPECT_TRUE(matchAndVerifyResultTrue(
-      Code2, ForEachOverriddenInClass("B"),
-      llvm::make_unique>("overridden", "f",
-                                                          2)));
-  // A1::f overrides nothing.
-  EXPECT_TRUE(notMatches(Code2, ForEachOverriddenInClass("A1")));
-}
-
 } // namespace ast_matchers
 } // namespace clang