maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

add a fixme, ELF MCSection isn't quite right and weak unnamed globals are broken 

on linux (even though they are pointless, they shouldn't ICE).

llvm-svn: 93308
This commit is contained in:
Chris Lattner 2010-01-13 08:02:14 +00:00
parent ceb5a4e8f6
commit b0dc959e1d
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/Target/TargetLoweringObjectFile.cpp
View File

@ -578,6 +578,10 @@ SelectSectionForGlobal(const GlobalValue *GV, SectionKind Kind,
const char *Prefix = getSectionPrefixForUniqueGlobal(Kind);
SmallString<128> Name;
Name.append(Prefix, Prefix+strlen(Prefix));
// FIXME: This will fail for weak globals with no names, this also depends
// on the mangling behavior of makeNameProper to mangle the section name
// before construction. Instead, this should use getNameWithPrefix on the
// global variable and the MCSection printing code should do the mangling.
Mang->makeNameProper(Name, GV->getName());
return getELFSection(Name.str(),