maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[libomptarget][amdgpu] Convert an assert to print and offload_fail 

[libomptarget][amdgpu] Convert an assert to print and offload_fail

The kernel launched is supposed to be present in the binary, but a not yet
diagnosed bug means it is missing for some of the qmcpack test cases. Changing
from assert to print and offload_fail should help diagnose that and similar bugs.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D102378
This commit is contained in:
Jon Chesterfield 2021-05-13 17:31:35 +01:00
parent 3f2891db6d
commit b049870d3b
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
openmp/libomptarget/plugins/amdgpu/src/rtl.cpp
View File

@ -1764,11 +1764,15 @@ int32_t __tgt_rtl_run_target_team_region_locked(
KernelTy *KernelInfo = (KernelTy *)tgt_entry_ptr; KernelTy *KernelInfo = (KernelTy *)tgt_entry_ptr;
std::string kernel_name = std::string(KernelInfo->Name); std::string kernel_name = std::string(KernelInfo->Name);
if (KernelInfoTable[device_id].find(kernel_name) ==
KernelInfoTable[device_id].end()) {
DP("Kernel %s not found\n", kernel_name.c_str());
return OFFLOAD_FAIL;
}
uint32_t sgpr_count, vgpr_count, sgpr_spill_count, vgpr_spill_count; uint32_t sgpr_count, vgpr_count, sgpr_spill_count, vgpr_spill_count;
{ {
assert(KernelInfoTable[device_id].find(kernel_name) !=
KernelInfoTable[device_id].end());
auto it = KernelInfoTable[device_id][kernel_name]; auto it = KernelInfoTable[device_id][kernel_name];
sgpr_count = it.sgpr_count; sgpr_count = it.sgpr_count;
vgpr_count = it.vgpr_count; vgpr_count = it.vgpr_count;
@ -1832,8 +1836,6 @@ int32_t __tgt_rtl_run_target_team_region_locked(
packet->completion_signal = {0}; // may want a pool of signals packet->completion_signal = {0}; // may want a pool of signals
{ {
assert(KernelInfoTable[device_id].find(kernel_name) !=
KernelInfoTable[device_id].end());
auto it = KernelInfoTable[device_id][kernel_name]; auto it = KernelInfoTable[device_id][kernel_name];
packet->kernel_object = it.kernel_object; packet->kernel_object = it.kernel_object;
packet->private_segment_size = it.private_segment_size; packet->private_segment_size = it.private_segment_size;