maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lldb][NFC] Move lock scope where it should begin

This commit is contained in:
Tatyana Krasnukha 2019-12-26 15:31:14 +03:00
parent b7c45ac352
commit b0469eede2
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
View File

@ -2349,21 +2349,22 @@ void ProcessGDBRemote::RefreshStateAfterStop() {
m_thread_ids.clear(); m_thread_ids.clear();
m_thread_pcs.clear(); m_thread_pcs.clear();
// Set the thread stop info. It might have a "threads" key whose value is a // Set the thread stop info. It might have a "threads" key whose value is a
// list of all thread IDs in the current process, so m_thread_ids might get // list of all thread IDs in the current process, so m_thread_ids might get
// set. // set.
// Check to see if SetThreadStopInfo() filled in m_thread_ids?
if (m_thread_ids.empty()) {
// No, we need to fetch the thread list manually
UpdateThreadIDList();
}
// We might set some stop info's so make sure the thread list is up to
// date before we do that or we might overwrite what was computed here.
UpdateThreadListIfNeeded();
// Scope for the lock // Scope for the lock
{ {
// Check to see if SetThreadStopInfo() filled in m_thread_ids?
if (m_thread_ids.empty()) {
// No, we need to fetch the thread list manually
UpdateThreadIDList();
}
// We might set some stop info's so make sure the thread list is up to
// date before we do that or we might overwrite what was computed here.
UpdateThreadListIfNeeded();
// Lock the thread stack while we access it // Lock the thread stack while we access it
std::lock_guard<std::recursive_mutex> guard(m_last_stop_packet_mutex); std::lock_guard<std::recursive_mutex> guard(m_last_stop_packet_mutex);
// Get the number of stop packets on the stack // Get the number of stop packets on the stack