[lldb] Remove PluginInterface::GetPluginVersion

In all these years, we haven't found a use for this function (it has
zero callers). Lets just remove the boilerplate.

Differential Revision: https://reviews.llvm.org/D109600

lldb/include/lldb/Core/PluginInterface.h

@@ -20,8 +20,6 @@ public:
 
   virtual ConstString GetPluginName() = 0;
 
-  virtual uint32_t GetPluginVersion() = 0;
-
   PluginInterface(const PluginInterface &) = delete;
   PluginInterface &operator=(const PluginInterface &) = delete;
 };

lldb/include/lldb/Symbol/SymbolVendor.h

@@ -43,8 +43,6 @@ public:
   // PluginInterface protocol
   ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   std::unique_ptr<SymbolFile> m_sym_file_up; // A single symbol file. Subclasses
                                              // can add more of these if needed.

lldb/include/lldb/Target/ProcessTrace.h

@@ -42,8 +42,6 @@ public:
 
   ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
   Status DoDestroy() override;
 
   void RefreshStateAfterStop() override;

lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.cpp

@@ -835,5 +835,3 @@ ConstString ABIMacOSX_arm64::GetPluginNameStatic() {
   static ConstString g_plugin_name("ABIMacOSX_arm64");
   return g_plugin_name;
 }
-
-uint32_t ABIMacOSX_arm64::GetPluginVersion() { return 1; }

lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.h

@@ -80,8 +80,6 @@ public:
     return GetPluginNameStatic();
   }
 
-  uint32_t GetPluginVersion() override;
-
   lldb_private::Status
   SetReturnValueObject(lldb::StackFrameSP &frame_sp,
                        lldb::ValueObjectSP &new_value) override;

lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp

@@ -854,5 +854,3 @@ lldb_private::ConstString ABISysV_arm64::GetPluginNameStatic() {
 // PluginInterface protocol
 
 ConstString ABISysV_arm64::GetPluginName() { return GetPluginNameStatic(); }
-
-uint32_t ABISysV_arm64::GetPluginVersion() { return 1; }

lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.h

@@ -83,8 +83,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
   lldb::addr_t FixCodeAddress(lldb::addr_t pc) override;
   lldb::addr_t FixDataAddress(lldb::addr_t pc) override;
 

lldb/source/Plugins/ABI/ARC/ABISysV_arc.cpp

@@ -613,5 +613,3 @@ ConstString ABISysV_arc::GetPluginNameStatic() {
 ConstString ABISysV_arc::GetPluginName() {
   return GetPluginNameStatic();
 }
-
-uint32_t ABISysV_arc::GetPluginVersion() { return 1; }

lldb/source/Plugins/ABI/ARC/ABISysV_arc.h

@@ -88,8 +88,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 private:
   lldb::ValueObjectSP
   GetReturnValueObjectSimple(lldb_private::Thread &thread,

lldb/source/Plugins/ABI/ARM/ABIMacOSX_arm.cpp

@@ -2036,5 +2036,3 @@ lldb_private::ConstString ABIMacOSX_arm::GetPluginNameStatic() {
 lldb_private::ConstString ABIMacOSX_arm::GetPluginName() {
   return GetPluginNameStatic();
 }
-
-uint32_t ABIMacOSX_arm::GetPluginVersion() { return 1; }

lldb/source/Plugins/ABI/ARM/ABIMacOSX_arm.h

@@ -77,8 +77,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   lldb::ValueObjectSP
   GetReturnValueObjectImpl(lldb_private::Thread &thread,

lldb/source/Plugins/ABI/ARM/ABISysV_arm.cpp

@@ -2142,5 +2142,3 @@ lldb_private::ConstString ABISysV_arm::GetPluginNameStatic() {
 lldb_private::ConstString ABISysV_arm::GetPluginName() {
   return GetPluginNameStatic();
 }
-
-uint32_t ABISysV_arm::GetPluginVersion() { return 1; }

lldb/source/Plugins/ABI/ARM/ABISysV_arm.h

@@ -77,8 +77,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   lldb::ValueObjectSP
   GetReturnValueObjectImpl(lldb_private::Thread &thread,

lldb/source/Plugins/ABI/Hexagon/ABISysV_hexagon.cpp

@@ -1288,8 +1288,6 @@ lldb_private::ConstString ABISysV_hexagon::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t ABISysV_hexagon::GetPluginVersion() { return 1; }
-
 // get value object specialized to work with llvm IR types
 lldb::ValueObjectSP
 ABISysV_hexagon::GetReturnValueObjectImpl(lldb_private::Thread &thread,

lldb/source/Plugins/ABI/Hexagon/ABISysV_hexagon.h

@@ -85,8 +85,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   void CreateRegisterMapIfNeeded();
 

lldb/source/Plugins/ABI/Mips/ABISysV_mips.cpp

@@ -1063,5 +1063,3 @@ lldb_private::ConstString ABISysV_mips::GetPluginNameStatic() {
 lldb_private::ConstString ABISysV_mips::GetPluginName() {
   return GetPluginNameStatic();
 }
-
-uint32_t ABISysV_mips::GetPluginVersion() { return 1; }

lldb/source/Plugins/ABI/Mips/ABISysV_mips.h

@@ -75,8 +75,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   void CreateRegisterMapIfNeeded();
 

lldb/source/Plugins/ABI/Mips/ABISysV_mips64.cpp

@@ -1211,5 +1211,3 @@ lldb_private::ConstString ABISysV_mips64::GetPluginNameStatic() {
 lldb_private::ConstString ABISysV_mips64::GetPluginName() {
   return GetPluginNameStatic();
 }
-
-uint32_t ABISysV_mips64::GetPluginVersion() { return 1; }

lldb/source/Plugins/ABI/Mips/ABISysV_mips64.h

@@ -88,8 +88,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   void CreateRegisterMapIfNeeded();
 

lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.cpp

@@ -974,5 +974,3 @@ lldb_private::ConstString ABISysV_ppc::GetPluginNameStatic() {
 lldb_private::ConstString ABISysV_ppc::GetPluginName() {
   return GetPluginNameStatic();
 }
-
-uint32_t ABISysV_ppc::GetPluginVersion() { return 1; }

lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.h

@@ -84,8 +84,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   void CreateRegisterMapIfNeeded();
 

lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc64.cpp

@@ -1085,5 +1085,3 @@ lldb_private::ConstString ABISysV_ppc64::GetPluginNameStatic() {
 lldb_private::ConstString ABISysV_ppc64::GetPluginName() {
   return GetPluginNameStatic();
 }
-
-uint32_t ABISysV_ppc64::GetPluginVersion() { return 1; }

lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc64.h

@@ -84,8 +84,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   void CreateRegisterMapIfNeeded();
 

lldb/source/Plugins/ABI/SystemZ/ABISysV_s390x.cpp

@@ -727,5 +727,3 @@ lldb_private::ConstString ABISysV_s390x::GetPluginNameStatic() {
 lldb_private::ConstString ABISysV_s390x::GetPluginName() {
   return GetPluginNameStatic();
 }
-
-uint32_t ABISysV_s390x::GetPluginVersion() { return 1; }

lldb/source/Plugins/ABI/SystemZ/ABISysV_s390x.h

@@ -76,8 +76,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   void CreateRegisterMapIfNeeded();
 

lldb/source/Plugins/ABI/X86/ABIMacOSX_i386.cpp

@@ -471,5 +471,3 @@ lldb_private::ConstString ABIMacOSX_i386::GetPluginNameStatic() {
 lldb_private::ConstString ABIMacOSX_i386::GetPluginName() {
   return GetPluginNameStatic();
 }
-
-uint32_t ABIMacOSX_i386::GetPluginVersion() { return 1; }

lldb/source/Plugins/ABI/X86/ABIMacOSX_i386.h

@@ -79,8 +79,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   lldb::ValueObjectSP
   GetReturnValueObjectImpl(lldb_private::Thread &thread,

lldb/source/Plugins/ABI/X86/ABISysV_i386.h

@@ -87,8 +87,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override { return 1; }
-
 protected:
   lldb::ValueObjectSP
   GetReturnValueObjectSimple(lldb_private::Thread &thread,

lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp

@@ -963,5 +963,3 @@ lldb_private::ConstString ABISysV_x86_64::GetPluginNameStatic() {
 lldb_private::ConstString ABISysV_x86_64::GetPluginName() {
   return GetPluginNameStatic();
 }
-
-uint32_t ABISysV_x86_64::GetPluginVersion() { return 1; }

lldb/source/Plugins/ABI/X86/ABISysV_x86_64.h

@@ -82,8 +82,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   void CreateRegisterMapIfNeeded();
 

lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.cpp

@@ -836,5 +836,3 @@ lldb_private::ConstString ABIWindows_x86_64::GetPluginNameStatic() {
 lldb_private::ConstString ABIWindows_x86_64::GetPluginName() {
   return GetPluginNameStatic();
 }
-
-uint32_t ABIWindows_x86_64::GetPluginVersion() { return 1; }

lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.h

@@ -75,8 +75,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   void CreateRegisterMapIfNeeded();
 

lldb/source/Plugins/Architecture/AArch64/ArchitectureAArch64.cpp

@@ -42,4 +42,3 @@ ArchitectureAArch64::Create(const ArchSpec &arch) {
 ConstString ArchitectureAArch64::GetPluginName() {
   return GetPluginNameStatic();
 }
-uint32_t ArchitectureAArch64::GetPluginVersion() { return 1; }

lldb/source/Plugins/Architecture/AArch64/ArchitectureAArch64.h

@@ -21,7 +21,6 @@ public:
   static void Terminate();
 
   ConstString GetPluginName() override;
-  uint32_t GetPluginVersion() override;
 
   void OverrideStopInfo(Thread &thread) const override{};
 

lldb/source/Plugins/Architecture/Arm/ArchitectureArm.cpp

@@ -40,7 +40,6 @@ std::unique_ptr<Architecture> ArchitectureArm::Create(const ArchSpec &arch) {
 }
 
 ConstString ArchitectureArm::GetPluginName() { return GetPluginNameStatic(); }
-uint32_t ArchitectureArm::GetPluginVersion() { return 1; }
 
 void ArchitectureArm::OverrideStopInfo(Thread &thread) const {
   // We need to check if we are stopped in Thumb mode in a IT instruction and

lldb/source/Plugins/Architecture/Arm/ArchitectureArm.h

@@ -20,7 +20,6 @@ public:
   static void Terminate();
 
   ConstString GetPluginName() override;
-  uint32_t GetPluginVersion() override;
 
   void OverrideStopInfo(Thread &thread) const override;
 

lldb/source/Plugins/Architecture/Mips/ArchitectureMips.cpp

@@ -43,7 +43,6 @@ std::unique_ptr<Architecture> ArchitectureMips::Create(const ArchSpec &arch) {
 }
 
 ConstString ArchitectureMips::GetPluginName() { return GetPluginNameStatic(); }
-uint32_t ArchitectureMips::GetPluginVersion() { return 1; }
 
 addr_t ArchitectureMips::GetCallableLoadAddress(addr_t code_addr,
                                                 AddressClass addr_class) const {

lldb/source/Plugins/Architecture/Mips/ArchitectureMips.h

@@ -21,7 +21,6 @@ public:
   static void Terminate();
 
   ConstString GetPluginName() override;
-  uint32_t GetPluginVersion() override;
 
   void OverrideStopInfo(Thread &thread) const override {}
 

lldb/source/Plugins/Architecture/PPC64/ArchitecturePPC64.cpp

@@ -44,7 +44,6 @@ std::unique_ptr<Architecture> ArchitecturePPC64::Create(const ArchSpec &arch) {
 }
 
 ConstString ArchitecturePPC64::GetPluginName() { return GetPluginNameStatic(); }
-uint32_t ArchitecturePPC64::GetPluginVersion() { return 1; }
 
 static int32_t GetLocalEntryOffset(const Symbol &sym) {
   unsigned char other = sym.GetFlags() >> 8 & 0xFF;

lldb/source/Plugins/Architecture/PPC64/ArchitecturePPC64.h

@@ -20,7 +20,6 @@ public:
   static void Terminate();
 
   ConstString GetPluginName() override;
-  uint32_t GetPluginVersion() override;
 
   void OverrideStopInfo(Thread &thread) const override {}
 

lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp

@@ -1425,5 +1425,3 @@ const char *DisassemblerLLVMC::SymbolLookup(uint64_t value, uint64_t *type_ptr,
 
 // PluginInterface protocol
 ConstString DisassemblerLLVMC::GetPluginName() { return GetPluginNameStatic(); }
-
-uint32_t DisassemblerLLVMC::GetPluginVersion() { return 1; }

lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.h

@@ -45,8 +45,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   friend class InstructionLLVMC;
 

lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp

@@ -1569,8 +1569,6 @@ lldb_private::ConstString DynamicLoaderDarwinKernel::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t DynamicLoaderDarwinKernel::GetPluginVersion() { return 1; }
-
 lldb::ByteOrder
 DynamicLoaderDarwinKernel::GetByteOrderFromMagic(uint32_t magic) {
   switch (magic) {

lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.h

@@ -60,8 +60,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   void PrivateInitialize(lldb_private::Process *process);
 

lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp

@@ -92,8 +92,6 @@ const char *DynamicLoaderHexagonDYLD::GetPluginDescriptionStatic() {
          "loads/unloads in Hexagon processes.";
 }
 
-uint32_t DynamicLoaderHexagonDYLD::GetPluginVersion() { return 1; }
-
 DynamicLoader *DynamicLoaderHexagonDYLD::CreateInstance(Process *process,
                                                         bool force) {
   bool create = force;

lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h

@@ -49,8 +49,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   /// Runtime linker rendezvous structure.
   HexagonDYLDRendezvous m_rendezvous;

lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp

@@ -518,5 +518,3 @@ const char *DynamicLoaderMacOS::GetPluginDescriptionStatic() {
 lldb_private::ConstString DynamicLoaderMacOS::GetPluginName() {
   return GetPluginNameStatic();
 }
-
-uint32_t DynamicLoaderMacOS::GetPluginVersion() { return 1; }

lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h

@@ -62,8 +62,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   void PutToLog(lldb_private::Log *log) const;
 

lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp

@@ -1151,8 +1151,6 @@ lldb_private::ConstString DynamicLoaderMacOSXDYLD::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t DynamicLoaderMacOSXDYLD::GetPluginVersion() { return 1; }
-
 uint32_t DynamicLoaderMacOSXDYLD::AddrByteSize() {
   std::lock_guard<std::recursive_mutex> baseclass_guard(GetMutex());
 

lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h

@@ -66,8 +66,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
   bool IsFullyInitialized() override;
 
 protected:

lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp

@@ -52,8 +52,6 @@ const char *DynamicLoaderPOSIXDYLD::GetPluginDescriptionStatic() {
          "loads/unloads in POSIX processes.";
 }
 
-uint32_t DynamicLoaderPOSIXDYLD::GetPluginVersion() { return 1; }
-
 DynamicLoader *DynamicLoaderPOSIXDYLD::CreateInstance(Process *process,
                                                       bool force) {
   bool create = force;

lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h

@@ -55,8 +55,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   /// Runtime linker rendezvous structure.
   DYLDRendezvous m_rendezvous;

lldb/source/Plugins/DynamicLoader/Static/DynamicLoaderStatic.cpp

@@ -166,5 +166,3 @@ const char *DynamicLoaderStatic::GetPluginDescriptionStatic() {
 lldb_private::ConstString DynamicLoaderStatic::GetPluginName() {
   return GetPluginNameStatic();
 }
-
-uint32_t DynamicLoaderStatic::GetPluginVersion() { return 1; }

lldb/source/Plugins/DynamicLoader/Static/DynamicLoaderStatic.h

@@ -46,8 +46,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 private:
   void LoadAllImagesAtFileAddresses();
 };

lldb/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp

@@ -178,8 +178,6 @@ ConstString DynamicLoaderWindowsDYLD::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t DynamicLoaderWindowsDYLD::GetPluginVersion() { return 1; }
-
 ThreadPlanSP
 DynamicLoaderWindowsDYLD::GetStepThroughTrampolinePlan(Thread &thread,
                                                        bool stop) {

lldb/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.h

@@ -40,7 +40,6 @@ public:
                                                   bool stop) override;
 
   ConstString GetPluginName() override;
-  uint32_t GetPluginVersion() override;
 
 protected:
   lldb::addr_t GetLoadAddress(lldb::ModuleSP executable);

lldb/source/Plugins/DynamicLoader/wasm-DYLD/DynamicLoaderWasmDYLD.h

@@ -38,7 +38,6 @@ public:
   /// PluginInterface protocol.
   /// \{
   ConstString GetPluginName() override { return GetPluginNameStatic(); }
-  uint32_t GetPluginVersion() override { return 1; }
   /// \}
 };
 

lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.h

@@ -87,8 +87,6 @@ public:
     return GetPluginNameStatic();
   }
 
-  uint32_t GetPluginVersion() override { return 1; }
-
   bool SetTargetTriple(const ArchSpec &arch) override;
 
   enum Mode { eModeInvalid = -1, eModeARM, eModeThumb };

lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h

@@ -48,8 +48,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override { return 1; }
-
   bool SetTargetTriple(const lldb_private::ArchSpec &arch) override;
 
   bool SupportsEmulatingInstructionsOfType(

lldb/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h

@@ -57,8 +57,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override { return 1; }
-
   bool SetTargetTriple(const lldb_private::ArchSpec &arch) override;
 
   EmulateInstructionMIPS(const lldb_private::ArchSpec &arch);

lldb/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h

@@ -55,8 +55,6 @@ public:
 
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override { return 1; }
-
   bool SetTargetTriple(const lldb_private::ArchSpec &arch) override;
 
   bool SupportsEmulatingInstructionsOfType(

lldb/source/Plugins/Instruction/PPC64/EmulateInstructionPPC64.h

@@ -46,8 +46,6 @@ public:
 
   ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override { return 1; }
-
   bool SetTargetTriple(const ArchSpec &arch) override;
 
   bool SupportsEmulatingInstructionsOfType(InstructionType inst_type) override {

lldb/source/Plugins/InstrumentationRuntime/ASan/InstrumentationRuntimeASan.h

@@ -37,8 +37,6 @@ public:
 
   virtual lldb::InstrumentationRuntimeType GetType() { return GetTypeStatic(); }
 
-  uint32_t GetPluginVersion() override { return 1; }
-
 private:
   InstrumentationRuntimeASan(const lldb::ProcessSP &process_sp)
       : lldb_private::InstrumentationRuntime(process_sp) {}

lldb/source/Plugins/InstrumentationRuntime/MainThreadChecker/InstrumentationRuntimeMainThreadChecker.h

@@ -38,8 +38,6 @@ public:
 
   virtual lldb::InstrumentationRuntimeType GetType() { return GetTypeStatic(); }
 
-  uint32_t GetPluginVersion() override { return 1; }
-
   lldb::ThreadCollectionSP
   GetBacktracesFromExtendedStopInfo(StructuredData::ObjectSP info) override;
 

lldb/source/Plugins/InstrumentationRuntime/TSan/InstrumentationRuntimeTSan.h

@@ -37,8 +37,6 @@ public:
 
   virtual lldb::InstrumentationRuntimeType GetType() { return GetTypeStatic(); }
 
-  uint32_t GetPluginVersion() override { return 1; }
-
   lldb::ThreadCollectionSP
   GetBacktracesFromExtendedStopInfo(StructuredData::ObjectSP info) override;
 

lldb/source/Plugins/InstrumentationRuntime/UBSan/InstrumentationRuntimeUBSan.h

@@ -38,8 +38,6 @@ public:
 
   virtual lldb::InstrumentationRuntimeType GetType() { return GetTypeStatic(); }
 
-  uint32_t GetPluginVersion() override { return 1; }
-
   lldb::ThreadCollectionSP
   GetBacktracesFromExtendedStopInfo(StructuredData::ObjectSP info) override;
 

lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp

@@ -438,8 +438,6 @@ lldb_private::ConstString JITLoaderGDB::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t JITLoaderGDB::GetPluginVersion() { return 1; }
-
 void JITLoaderGDB::Initialize() {
   PluginManager::RegisterPlugin(GetPluginNameStatic(),
                                 GetPluginDescriptionStatic(), CreateInstance,

lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.h

@@ -37,8 +37,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
   // JITLoader interface
   void DidAttach() override;
 

lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp

@@ -99,8 +99,6 @@ lldb_private::ConstString CPlusPlusLanguage::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t CPlusPlusLanguage::GetPluginVersion() { return 1; }
-
 // Static Functions
 
 Language *CPlusPlusLanguage::CreateInstance(lldb::LanguageType language) {

lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h

@@ -135,8 +135,6 @@ public:
 
   // PluginInterface protocol
   ConstString GetPluginName() override;
-
-  uint32_t GetPluginVersion() override;
 };
 
 } // namespace lldb_private

lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp

@@ -59,8 +59,6 @@ lldb_private::ConstString ObjCLanguage::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t ObjCLanguage::GetPluginVersion() { return 1; }
-
 // Static Functions
 
 Language *ObjCLanguage::CreateInstance(lldb::LanguageType language) {

lldb/source/Plugins/Language/ObjC/ObjCLanguage.h

@@ -157,8 +157,6 @@ public:
 
   // PluginInterface protocol
   ConstString GetPluginName() override;
-
-  uint32_t GetPluginVersion() override;
 };
 
 } // namespace lldb_private

lldb/source/Plugins/Language/ObjCPlusPlus/ObjCPlusPlusLanguage.cpp

@@ -44,8 +44,6 @@ lldb_private::ConstString ObjCPlusPlusLanguage::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t ObjCPlusPlusLanguage::GetPluginVersion() { return 1; }
-
 // Static Functions
 Language *ObjCPlusPlusLanguage::CreateInstance(lldb::LanguageType language) {
   switch (language) {

lldb/source/Plugins/Language/ObjCPlusPlus/ObjCPlusPlusLanguage.h

@@ -44,8 +44,6 @@ public:
 
   // PluginInterface protocol
   ConstString GetPluginName() override;
-
-  uint32_t GetPluginVersion() override;
 };
 
 } // namespace lldb_private

lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp

@@ -415,8 +415,6 @@ lldb_private::ConstString ItaniumABILanguageRuntime::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t ItaniumABILanguageRuntime::GetPluginVersion() { return 1; }
-
 BreakpointResolverSP ItaniumABILanguageRuntime::CreateExceptionResolver(
     const BreakpointSP &bkpt, bool catch_bp, bool throw_bp) {
   return CreateExceptionResolver(bkpt, catch_bp, throw_bp, false);

lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.h

@@ -78,8 +78,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   lldb::BreakpointResolverSP
   CreateExceptionResolver(const lldb::BreakpointSP &bkpt,

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp

@@ -102,8 +102,6 @@ ConstString AppleObjCRuntimeV1::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t AppleObjCRuntimeV1::GetPluginVersion() { return 1; }
-
 BreakpointResolverSP
 AppleObjCRuntimeV1::CreateExceptionResolver(const BreakpointSP &bkpt,
                                             bool catch_bp, bool throw_bp) {

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.h

@@ -109,8 +109,6 @@ public:
   // PluginInterface protocol
   ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
   ObjCRuntimeVersions GetRuntimeVersion() const override {
     return ObjCRuntimeVersions::eAppleObjC_V1;
   }

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

@@ -1070,8 +1070,6 @@ lldb_private::ConstString AppleObjCRuntimeV2::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t AppleObjCRuntimeV2::GetPluginVersion() { return 1; }
-
 BreakpointResolverSP
 AppleObjCRuntimeV2::CreateExceptionResolver(const BreakpointSP &bkpt,
                                             bool catch_bp, bool throw_bp) {

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.h

@@ -56,8 +56,6 @@ public:
 
   ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
   ObjCRuntimeVersions GetRuntimeVersion() const override {
     return ObjCRuntimeVersions::eAppleObjC_V2;
   }

lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp

@@ -1019,8 +1019,6 @@ lldb_private::ConstString RenderScriptRuntime::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t RenderScriptRuntime::GetPluginVersion() { return 1; }
-
 bool RenderScriptRuntime::GetDynamicTypeAndAddress(
     ValueObject &in_value, lldb::DynamicValueType use_dynamic,
     TypeAndOrName &class_type_or_name, Address &address,

lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.h

@@ -412,8 +412,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
   static bool GetKernelCoordinate(lldb_renderscript::RSCoordinate &coord,
                                   Thread *thread_ptr);
 

lldb/source/Plugins/MemoryHistory/asan/MemoryHistoryASan.h

@@ -33,8 +33,6 @@ public:
     return GetPluginNameStatic();
   }
 
-  uint32_t GetPluginVersion() override { return 1; }
-
   lldb_private::HistoryThreads GetHistoryThreads(lldb::addr_t address) override;
 
 private:

lldb/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp

@@ -438,8 +438,6 @@ lldb_private::ConstString ObjectContainerBSDArchive::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t ObjectContainerBSDArchive::GetPluginVersion() { return 1; }
-
 size_t ObjectContainerBSDArchive::GetModuleSpecifications(
     const lldb_private::FileSpec &file, lldb::DataBufferSP &data_sp,
     lldb::offset_t data_offset, lldb::offset_t file_offset,

lldb/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.h

@@ -70,8 +70,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   struct Object {
     Object();

lldb/source/Plugins/ObjectContainer/Universal-Mach-O/ObjectContainerUniversalMachO.cpp

@@ -210,8 +210,6 @@ lldb_private::ConstString ObjectContainerUniversalMachO::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t ObjectContainerUniversalMachO::GetPluginVersion() { return 1; }
-
 size_t ObjectContainerUniversalMachO::GetModuleSpecifications(
     const lldb_private::FileSpec &file, lldb::DataBufferSP &data_sp,
     lldb::offset_t data_offset, lldb::offset_t file_offset,

lldb/source/Plugins/ObjectContainer/Universal-Mach-O/ObjectContainerUniversalMachO.h

@@ -61,8 +61,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   llvm::MachO::fat_header m_header;
   std::vector<llvm::MachO::fat_arch> m_fat_archs;

lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.h

@@ -46,8 +46,6 @@ public:
   // PluginInterface protocol
   ConstString GetPluginName() override { return GetPluginNameStatic(); }
 
-  uint32_t GetPluginVersion() override { return 1; }
-
   // LLVM RTTI support
   static char ID;
   bool isA(const void *ClassID) const override {

lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

@@ -639,7 +639,6 @@ lldb_private::ConstString ObjectFileELF::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t ObjectFileELF::GetPluginVersion() { return m_plugin_version; }
 // ObjectFile protocol
 
 ObjectFileELF::ObjectFileELF(const lldb::ModuleSP &module_sp,

lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h

@@ -87,8 +87,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
   // LLVM RTTI support
   static char ID;
   bool isA(const void *ClassID) const override {

lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp

@@ -204,8 +204,6 @@ lldb_private::ConstString ObjectFileJIT::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t ObjectFileJIT::GetPluginVersion() { return 1; }
-
 bool ObjectFileJIT::SetLoadAddress(Target &target, lldb::addr_t value,
                                    bool value_is_offset) {
   size_t num_loaded_sections = 0;

lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.h

@@ -98,8 +98,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   lldb::ObjectFileJITDelegateWP m_delegate_wp;
 };

lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

@@ -6173,8 +6173,6 @@ lldb_private::ConstString ObjectFileMachO::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t ObjectFileMachO::GetPluginVersion() { return 1; }
-
 Section *ObjectFileMachO::GetMachHeaderSection() {
   // Find the first address of the mach header which is the first non-zero file
   // sized section whose file offset is zero. This is the base file address of

lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h

@@ -148,8 +148,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
 protected:
   static lldb_private::UUID
   GetUUID(const llvm::MachO::mach_header &header,

lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.h

@@ -55,8 +55,6 @@ public:
                                         lldb::offset_t length,
                                         lldb_private::ModuleSpecList &specs);
 
-  uint32_t GetPluginVersion() override { return 1; }
-
   // Saves dump in Minidump file format
   static bool SaveCore(const lldb::ProcessSP &process_sp,
                        const lldb_private::FileSpec &outfile,
@@ -67,4 +65,4 @@ private:
   ObjectFileMinidump() = default;
 };
 
-#endif // LLDB_SOURCE_PLUGINS_OBJECTFILE_MINIDUMP_OBJECTFILEMINIDUMP_H
+#endif // LLDB_SOURCE_PLUGINS_OBJECTFILE_MINIDUMP_OBJECTFILEMINIDUMP_H

lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.h

@@ -50,8 +50,6 @@ public:
   // PluginInterface protocol
   ConstString GetPluginName() override { return GetPluginNameStatic(); }
 
-  uint32_t GetPluginVersion() override { return 1; }
-
   // LLVM RTTI support
   static char ID;
   bool isA(const void *ClassID) const override {

lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

@@ -1208,5 +1208,3 @@ ObjectFile::Strata ObjectFilePECOFF::CalculateStrata() { return eStrataUser; }
 
 // PluginInterface protocol
 ConstString ObjectFilePECOFF::GetPluginName() { return GetPluginNameStatic(); }
-
-uint32_t ObjectFilePECOFF::GetPluginVersion() { return 1; }

lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h

@@ -132,8 +132,6 @@ public:
   // PluginInterface protocol
   lldb_private::ConstString GetPluginName() override;
 
-  uint32_t GetPluginVersion() override;
-
   bool IsWindowsSubsystem();
 
   uint32_t GetRVA(const lldb_private::Address &addr) const;

lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.h

@@ -49,7 +49,6 @@ public:
   /// PluginInterface protocol.
   /// \{
   ConstString GetPluginName() override { return GetPluginNameStatic(); }
-  uint32_t GetPluginVersion() override { return 1; }
   /// \}
 
   /// LLVM RTTI support

lldb/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp

@@ -146,8 +146,6 @@ ConstString OperatingSystemPython::GetPluginName() {
   return GetPluginNameStatic();
 }
 
-uint32_t OperatingSystemPython::GetPluginVersion() { return 1; }
-
 bool OperatingSystemPython::UpdateThreadList(ThreadList &old_thread_list,
                                              ThreadList &core_thread_list,
                                              ThreadList &new_thread_list) {