maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[GlobalISel] Mark memcpy/memmove/memset as thisreturn 

https://clang.godbolt.org/z/9az64j8W6

rdar://77466123

Differential revision: https://reviews.llvm.org/D105370
This commit is contained in:
Jon Roelofs 2021-07-02 13:08:57 -07:00
parent 3de06260f7
commit afaf92826e
3 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
View File

@ -580,15 +580,18 @@ llvm::createMemLibcall(MachineIRBuilder &MIRBuilder, MachineRegisterInfo &MRI,
break; break;
case TargetOpcode::G_MEMCPY: case TargetOpcode::G_MEMCPY:
RTLibcall = RTLIB::MEMCPY; RTLibcall = RTLIB::MEMCPY;
Args[0].Flags[0].setReturned();
break; break;
case TargetOpcode::G_MEMMOVE: case TargetOpcode::G_MEMMOVE:
RTLibcall = RTLIB::MEMMOVE; RTLibcall = RTLIB::MEMMOVE;
Args[0].Flags[0].setReturned();
break; break;
case TargetOpcode::G_MEMSET: case TargetOpcode::G_MEMSET:
RTLibcall = RTLIB::MEMSET; RTLibcall = RTLIB::MEMSET;
Args[0].Flags[0].setReturned();
break; break;
default: default:
return LegalizerHelper::UnableToLegalize; llvm_unreachable("unsupported opcode");
} }
const char *Name = TLI.getLibcallName(RTLibcall); const char *Name = TLI.getLibcallName(RTLibcall);
@ -610,7 +613,6 @@ llvm::createMemLibcall(MachineIRBuilder &MIRBuilder, MachineRegisterInfo &MRI,
if (!CLI.lowerCall(MIRBuilder, Info)) if (!CLI.lowerCall(MIRBuilder, Info))
return LegalizerHelper::UnableToLegalize; return LegalizerHelper::UnableToLegalize;
if (Info.LoweredTailCall) { if (Info.LoweredTailCall) {
assert(Info.IsTailCall && "Lowered tail call when it wasn't a tail call?"); assert(Info.IsTailCall && "Lowered tail call when it wasn't a tail call?");

10
llvm/test/CodeGen/AArch64/GlobalISel/legalize-memcpy-et-al.mir
View File

@ -18,7 +18,7 @@ body: |
; CHECK: $x0 = COPY [[COPY]](p0) ; CHECK: $x0 = COPY [[COPY]](p0)
; CHECK: $x1 = COPY [[COPY1]](p0) ; CHECK: $x1 = COPY [[COPY1]](p0)
; CHECK: $x2 = COPY [[ZEXT]](s64) ; CHECK: $x2 = COPY [[ZEXT]](s64)
; CHECK: BL &memcpy, csr_aarch64_aapcs, implicit-def $lr, implicit $sp, implicit $x0, implicit $x1, implicit $x2 ; CHECK: BL &memcpy, csr_aarch64_aapcs_thisreturn, implicit-def $lr, implicit $sp, implicit $x0, implicit $x1, implicit $x2
; CHECK: ADJCALLSTACKUP 0, 0, implicit-def $sp, implicit $sp ; CHECK: ADJCALLSTACKUP 0, 0, implicit-def $sp, implicit $sp
; CHECK: RET_ReallyLR ; CHECK: RET_ReallyLR
%0:_(p0) = COPY $x0 %0:_(p0) = COPY $x0
@ -71,7 +71,7 @@ body: |
; CHECK: $x0 = COPY [[COPY]](p0) ; CHECK: $x0 = COPY [[COPY]](p0)
; CHECK: $x1 = COPY [[COPY1]](p0) ; CHECK: $x1 = COPY [[COPY1]](p0)
; CHECK: $x2 = COPY [[ZEXT]](s64) ; CHECK: $x2 = COPY [[ZEXT]](s64)
; CHECK: BL &memmove, csr_aarch64_aapcs, implicit-def $lr, implicit $sp, implicit $x0, implicit $x1, implicit $x2 ; CHECK: BL &memmove, csr_aarch64_aapcs_thisreturn, implicit-def $lr, implicit $sp, implicit $x0, implicit $x1, implicit $x2
; CHECK: ADJCALLSTACKUP 0, 0, implicit-def $sp, implicit $sp ; CHECK: ADJCALLSTACKUP 0, 0, implicit-def $sp, implicit $sp
; CHECK: RET_ReallyLR ; CHECK: RET_ReallyLR
%0:_(p0) = COPY $x0 %0:_(p0) = COPY $x0
@ -100,7 +100,7 @@ body: |
; CHECK: [[COPY3:%[0-9]+]]:_(s32) = COPY [[COPY1]](s32) ; CHECK: [[COPY3:%[0-9]+]]:_(s32) = COPY [[COPY1]](s32)
; CHECK: $w1 = COPY [[COPY3]](s32) ; CHECK: $w1 = COPY [[COPY3]](s32)
; CHECK: $x2 = COPY [[ZEXT]](s64) ; CHECK: $x2 = COPY [[ZEXT]](s64)
; CHECK: BL &memset, csr_aarch64_aapcs, implicit-def $lr, implicit $sp, implicit $x0, implicit $w1, implicit $x2 ; CHECK: BL &memset, csr_aarch64_aapcs_thisreturn, implicit-def $lr, implicit $sp, implicit $x0, implicit $w1, implicit $x2
; CHECK: ADJCALLSTACKUP 0, 0, implicit-def $sp, implicit $sp ; CHECK: ADJCALLSTACKUP 0, 0, implicit-def $sp, implicit $sp
; CHECK: RET_ReallyLR ; CHECK: RET_ReallyLR
%0:_(p0) = COPY $x0 %0:_(p0) = COPY $x0
@ -129,7 +129,7 @@ body: |
; CHECK: $x0 = COPY [[COPY]](p0) ; CHECK: $x0 = COPY [[COPY]](p0)
; CHECK: $x1 = COPY [[COPY1]](p0) ; CHECK: $x1 = COPY [[COPY1]](p0)
; CHECK: $x2 = COPY [[ZEXT]](s64) ; CHECK: $x2 = COPY [[ZEXT]](s64)
; CHECK: BL &memcpy, csr_aarch64_aapcs, implicit-def $lr, implicit $sp, implicit $x0, implicit $x1, implicit $x2 ; CHECK: BL &memcpy, csr_aarch64_aapcs_thisreturn, implicit-def $lr, implicit $sp, implicit $x0, implicit $x1, implicit $x2
; CHECK: ADJCALLSTACKUP 0, 0, implicit-def $sp, implicit $sp ; CHECK: ADJCALLSTACKUP 0, 0, implicit-def $sp, implicit $sp
; CHECK: $x0 = COPY [[ZEXT]](s64) ; CHECK: $x0 = COPY [[ZEXT]](s64)
; CHECK: RET_ReallyLR implicit $x0 ; CHECK: RET_ReallyLR implicit $x0
@ -158,7 +158,7 @@ body: |
; CHECK: $x0 = COPY [[COPY]](p0) ; CHECK: $x0 = COPY [[COPY]](p0)
; CHECK: $x1 = COPY [[COPY1]](p0) ; CHECK: $x1 = COPY [[COPY1]](p0)
; CHECK: $x2 = COPY [[ZEXT]](s64) ; CHECK: $x2 = COPY [[ZEXT]](s64)
; CHECK: BL &memcpy, csr_aarch64_aapcs, implicit-def $lr, implicit $sp, implicit $x0, implicit $x1, implicit $x2 ; CHECK: BL &memcpy, csr_aarch64_aapcs_thisreturn, implicit-def $lr, implicit $sp, implicit $x0, implicit $x1, implicit $x2
; CHECK: ADJCALLSTACKUP 0, 0, implicit-def $sp, implicit $sp ; CHECK: ADJCALLSTACKUP 0, 0, implicit-def $sp, implicit $sp
; CHECK: TCRETURNdi &memset, 0, csr_aarch64_aapcs, implicit $sp ; CHECK: TCRETURNdi &memset, 0, csr_aarch64_aapcs, implicit $sp
%0:_(p0) = COPY $x0 %0:_(p0) = COPY $x0

2
llvm/test/CodeGen/AArch64/GlobalISel/legalize-memlib-debug-loc.mir
View File

@ -47,7 +47,7 @@ body: |
; We're checking that the BL call has the debug loc of the original intrinsic call. ; We're checking that the BL call has the debug loc of the original intrinsic call.
; CHECK-LABEL: name: test_memset_debug ; CHECK-LABEL: name: test_memset_debug
; CHECK: BL &memset, csr_aarch64_aapcs, implicit-def $lr, implicit $sp, implicit $x0, implicit $w1, implicit $x2, debug-location !11 ; CHECK: BL &memset, csr_aarch64_aapcs_thisreturn, implicit-def $lr, implicit $sp, implicit $x0, implicit $w1, implicit $x2, debug-location !11
; CHECK: RET_ReallyLR debug-location !12 ; CHECK: RET_ReallyLR debug-location !12
%0:_(p0) = COPY $x0 %0:_(p0) = COPY $x0
%1:_(s32) = COPY $w1 %1:_(s32) = COPY $w1