forked from OSchip/llvm-project
[lldb] Don't dump the frame in SBTarget::EvaluateExpression in LLDB_CONFIGURATION_DEBUG
Summary: Dumping the frame using the user-set format could cause that a debug LLDB doesn't behave as a release LLDB, which could potentially break replaying a reproducer. Also it's kinda strange that the frame format set by the user is used in the internal log output. Reviewers: JDevlieghere Reviewed By: JDevlieghere Differential Revision: https://reviews.llvm.org/D76685
This commit is contained in:
parent
1a083f027f
commit
aef982e35a
|
@ -2340,16 +2340,6 @@ lldb::SBValue SBTarget::EvaluateExpression(const char *expr,
|
|||
Target *target = exe_ctx.GetTargetPtr();
|
||||
|
||||
if (target) {
|
||||
#ifdef LLDB_CONFIGURATION_DEBUG
|
||||
StreamString frame_description;
|
||||
if (frame)
|
||||
frame->DumpUsingSettingsFormat(&frame_description);
|
||||
llvm::PrettyStackTraceFormat stack_trace(
|
||||
"SBTarget::EvaluateExpression (expr = \"%s\", fetch_dynamic_value = "
|
||||
"%u) %s",
|
||||
expr, options.GetFetchDynamicValue(),
|
||||
frame_description.GetString().str().c_str());
|
||||
#endif
|
||||
target->EvaluateExpression(expr, frame, expr_value_sp, options.ref());
|
||||
|
||||
expr_result.SetSP(expr_value_sp, options.GetFetchDynamicValue());
|
||||
|
|
Loading…
Reference in New Issue